-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add strictSSL query param toggle to [coverity] #3336
Conversation
|
With Jenkins CI, I think its right for this to be user-configurable because its not a centralised service. We should assume that usually we can contact a jenkins instance with Coverity is different because its a centralised service. We know we're going to get an SSL error attempting to call https://scan.coverity.com/ in all cases (at leats until the cert changes upstream). There is no user who doesn't need to add |
That works for me 👍 |
Close #3334
As detailed in #3334, Coverity has a cert chain issue which prevents us from being able to render our Coverity badges (internally, we get
Inaccessible: unable to verify the first certificate
errors on cert chain issues, the badges render asinaccessible
). We've seen this with a couple other services (or instances of self-hosted tools, like #1956)Ideally the upstream providers would resolve, but our Coverity badge users have expressed understandable concern around the timeframe for if/when Coverity (Synopsys) would be able to resolve this. We receive the cert verification error on both Node 8.x and 10.x so I believe it's an issue that we'll need to address.
This proposed solution adds a new a new query param
disableStrictSSL
that will allow the user to opt-in to disabling the strict ssl check, thus re-enabling Coverity badges. It's the same solution we seem to be going with for JenkinsDefault behavior (strict ssl check enabled per
request
's defaults):https://shields-staging-pr-3336.herokuapp.com/coverity/scan/3997.svg
https://shields-staging-pr-3336.herokuapp.com/coverity/scan/3997.svg?disableStrictSSL