Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template literal templates #4459

Merged
merged 32 commits into from
Jan 9, 2020
Merged

Template literal templates #4459

merged 32 commits into from
Jan 9, 2020

Commits on Dec 23, 2019

  1. add a bunch more snapshot tests

    @chris48s
    chris48s committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    fcf6c68 View commit details
    Browse the repository at this point in the history

  2. WIP: this is _roughly_ where Paul got to in badges#3637

    @paulmelnikow @chris48s
    paulmelnikow authored and chris48s committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    058fa48 View commit details
    Browse the repository at this point in the history

  3. get flat/flat-square/plastic working 

    get flat, flat-square and plastic styles working
+ factor out common code to a base class
    @chris48s
    chris48s committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    591ce21 View commit details
    Browse the repository at this point in the history

  4. get FTB working

    @chris48s
    chris48s committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    a616528 View commit details
    Browse the repository at this point in the history

  5. escape logo

    @chris48s
    chris48s committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    1944de9 View commit details
    Browse the repository at this point in the history

  6. fix social logo rendering

    @chris48s
    chris48s committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    4e7c4d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2019

  1. fix badges with only message and logo, cleanup in FTB

    @chris48s
    chris48s committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    7eae7df View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2019

  1. fix link rendering code

    @chris48s
    chris48s committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    db6817e View commit details
    Browse the repository at this point in the history

  2. fix social badge link rendering, tidy up

    @chris48s
    chris48s committed Dec 29, 2019
    Configuration menu
    Copy the full SHA
    c2bf4fd View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. manually optimise: scale(0.1) --> scale(.1)

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    286636d View commit details
    Browse the repository at this point in the history

  2. manually optimise: remove lengthAdjust="spacing" 

    this is the default
    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    8e62a86 View commit details
    Browse the repository at this point in the history

  3. manually optimise: one character var names

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    b877bc9 View commit details
    Browse the repository at this point in the history

  4. manually optimise: whitespace

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    2f62ab7 View commit details
    Browse the repository at this point in the history

  5. var names cleanup

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    be11eba View commit details
    Browse the repository at this point in the history

  6. Re-generate snapshots 

    This accounts for several things:

1. Changes in one-char variable names
2. Removed some whitespace
3. I've dropped the <rect> to <path> optimisation
    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    ed24253 View commit details
    Browse the repository at this point in the history

  7. remove dot and SVGO from package deps

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    9bbb2a4 View commit details
    Browse the repository at this point in the history

  8. add massive pile of tests

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    5bba06f View commit details
    Browse the repository at this point in the history

  9. remove pointless assignment

    @chris48s
    chris48s committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    a1eb9cb View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. don't double-escape logo

    @chris48s
    chris48s committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    735c03c View commit details
    Browse the repository at this point in the history

  2. early returns

    @chris48s
    chris48s committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    a47f9cc View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. remove colorscheme/colorA/colorB

    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    732ff0c View commit details
    Browse the repository at this point in the history

  2. throw exception in lib for popout styles, fallback in coalesce

    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    93115dd View commit details
    Browse the repository at this point in the history

  3. throw error on invalid template, don't assume flat

    @chris48s
    chris48s committed Jan 5, 2020
    1 Configuration menu
    Copy the full SHA
    619d850 View commit details
    Browse the repository at this point in the history

  4. simplify labelColor computation 

    labelColor is always true anyway now we've given the param a default
    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    ccdc468 View commit details
    Browse the repository at this point in the history

  5. remove unused param (we've already applied logoColor by the time we g… 

    …et here)
    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    0db6b52 View commit details
    Browse the repository at this point in the history

  6. move all the snapshot tests out a layer

    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    62529b2 View commit details
    Browse the repository at this point in the history

  7. use realistic logo example/delete meaningless tests 

    at this layer of the application, a logo
should already be a base64 encoded string.

`logo: 'javascript'` renders
<image x="5" y="3" width="14" height="14" xlink:href="javascript"/>
which isn't really what we want to test

Passing logoColor to makeBadge() is completely meaningless
    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    9470b82 View commit details
    Browse the repository at this point in the history

  8. re-generate test snapshots

    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    19224e5 View commit details
    Browse the repository at this point in the history

  9. throw with different error message

    @chris48s
    chris48s committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    1a83138 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. express logo X and Y more clearly, fix plastic logo placement

    @chris48s
    chris48s committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    c5ef23a View commit details
    Browse the repository at this point in the history

  2. Add test page

    @paulmelnikow @chris48s
    paulmelnikow authored and chris48s committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    d5fe0e6 View commit details
    Browse the repository at this point in the history

  3. fix FTB style with logo but no label

    @chris48s
    chris48s committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    34db0f2 View commit details
    Browse the repository at this point in the history