Fix rendering in Firefox on Windows

[ftoh]

Fix #4813
Complements #4979
May be fixed #4275

Should be tested on other OS

Documentation for text-rendering attribute:
https://developer.mozilla.org/ru/docs/Web/SVG/Attribute/text-rendering

Comparison

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @ftoh!

Generated by 🚫 dangerJS against 7d121a1

[paulmelnikow]

This is amazing @ftoh! Thanks so much for tracking this down!

I re-added DejaVu Sans at the end. Would you mind updating the snapshots again?

Otherwise I think this is good to merge.

@calebcartwright does this look good to you on all the platforms? @RedSparr0w @chris48s any concerns?

[chris48s]

Looks like there are still some failing tests - probably because the font order has changed.

The easiest thing to do is usually just to delete the snapshots file, re-run the package tests and then check the diff, rather than try to manually update the snapshots.

Beyond that, I think the core change here is useful

[calebcartwright]

What's the page/listing shown in the screenshots so that i can compare from ubuntu?

@paulmelnikow - not sure if this is what you were asking for but screenshots from Firefox on Ubuntu below

[paulmelnikow]

They look great, yea? Thanks!

[calebcartwright]

The changes in those screenshots on Windows look great.

I'm not sure if I was supposed to be able to see any differences on Linux. I felt a bit like this 😆
https://youtu.be/gW2LtX1217s?t=124

[paulmelnikow]

Thanks for this awesome contribution to Shields @ftoh! I so appreciate your digging into this, and helping us make good on our "pixel perfect" promise.

If you're interested in continuing to dig in on these kinds of issues there's lots to do!

These are two really impactful examples:

• Arabic text (Support Arabic text on badges #4140)
• Correct font-width computation for boldface type (Letter spacing is incorrect on social badges #4275)

Recently @chris48s and I rewrote all the badge generation using plain JavaScript and template literals, so it's much more readable and changeable than when they were DoT templates. (See #4459 and #3637. There is a lot of refactoring that can be done to make it even more readable.)

IIRC there are a handful of open issues relating to padding computations that are slightly off. With the code as it is now it should be pretty reasonable to track down the issues and fix them.

[ftoh]

@paulmelnikow When will the changes take effect?

[paulmelnikow]

It's live now!