-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate flat, flat-square, plastic and social to use XmlElement
#6883
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
81a09a9
start changelog entry for v4
chris48s b8822c3
migrate Flat/FlatSquare/Plastic to use XmlElement
chris48s a820225
move brightnessThreshold into colorsForBackground
chris48s 01f24c4
move old renderLogo function inline into social()
chris48s fd14c14
use XmlElement in social()
chris48s 66383ea
don't quote numbers if we don't need to
chris48s b577a03
remove intermediate calls to .render()
chris48s 23123fe
factor out code for assembling logo element
chris48s 138c525
use scale consts in social
chris48s f982039
remove NullElement
chris48s b6c5a10
Update badge-maker/lib/badge-renderers.js
chris48s 05f4f80
Revert "Update badge-maker/lib/badge-renderers.js"
chris48s 6df7949
write leftlink so it doesn't look like a bool
chris48s 870af64
Merge branch 'master' into xmlelement2
chris48s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly related to this PR but the next package release has to be v4 because we've dropped node10. I'm starting the changelog here so we don't lose sight of it.