[Flathub]Add downloads badge #7724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JakobDev <jakobdev@gmx.de>
|
Thank you for the PR! To avoid any bifurcation or loss of discussion for historical context, I'd recommend we first continue/resolve conversation back on the issue (especially the questions in #5506 (comment)) before diving to deeply into the proposed implementation |
|
This was closed by mistake due to a typo in an unrelated commit message, reopening |
calebcartwright
added
service-badge
|
In a holding pattern for now as the upstream service maintainers have stated they'd like to modify the API response before we start consuming |
|
@calebcartwright flathub-infra/website#67 has now been merged. I had updated my PR. This PR is now ready to merge. |
chris48s
approved these changes
May 10, 2022
|
I think this one is good to go. I'll leave it open in cast @calebcartwright wants to chime in before we merge but LGTM |
calebcartwright
approved these changes
May 11, 2022
calebcartwright
added
squash when passing
and removed
needs-upstream-help
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5506