Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a clarifying comment to [pypi] getLicenses #8718

Merged
merged 1 commit into from
Dec 15, 2022
Merged

add a clarifying comment to [pypi] getLicenses #8718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions services/pypi/pypi-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ function getLicenses(packageData) {
const {
info: { license },
} = packageData

/*
The .license field may either contain
- a short license description (e.g: 'MIT' or 'GPL-3.0') or
- the full text of a license
but there is nothing in the response that tells us explicitly.
We have to make an assumption based on the length.
See https://github.com/badges/shields/issues/8689 and
https://github.com/badges/shields/pull/8690 for more info.
*/
if (license && license.length < 40) {
return [license]
} else {
Expand Down