Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate [lgtm] #8771

Merged
merged 1 commit into from
Jan 4, 2023
Merged

deprecate [lgtm] #8771

merged 1 commit into from
Jan 4, 2023

Conversation

PaulaBarszcz
Copy link
Collaborator

Closes #8770

For now, I didn't touch lgtm/lgtm-redirector.service.js. We can probably delete this redirector in the same PR in which we will remove the deprecated LGTM services.

@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @PaulaBarszcz!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 654f7fc

@PaulaBarszcz
Copy link
Collaborator Author

@chris48s

Do you happen to know why this test failed? :)

https://github.com/PaulaBarszcz/shields/actions/runs/3832990295/jobs/6523944332

image

@chris48s
Copy link
Member

chris48s commented Jan 4, 2023

Do you happen to know why this test failed?

It looks like the build failed trying to download Node JS 17. I think its a transient failure - if you restart the build it'll probably just pass. Same build worked on the PR: https://github.com/badges/shields/actions/runs/3833016010/jobs/6523998906

@chris48s
Copy link
Member

chris48s commented Jan 4, 2023

Having had a look over this I think it is good to merge, but the PR is still marked as draft. Is there anything else you wanted to do to it?

@PaulaBarszcz PaulaBarszcz marked this pull request as ready for review January 4, 2023 19:27
@PaulaBarszcz
Copy link
Collaborator Author

PaulaBarszcz commented Jan 4, 2023

Having had a look over this I think it is good to merge, but the PR is still marked as draft. Is there anything else you wanted to do to it?

The only question was about the failing build, I am not planning on adding anything to this PR :) Marked as Ready for review, thanks

@chris48s chris48s added service-badge New or updated service badge squash when passing labels Jan 4, 2023
@repo-ranger repo-ranger bot merged commit bb1fda2 into badges:master Jan 4, 2023
@PaulaBarszcz PaulaBarszcz deleted the deprecate-lgtm branch January 4, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate LGTM
3 participants