fix service tests on windows; run [crates] (to prove service tests still run) #8786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8437
This doesn't fix the
:trace
variant but it does fix being able to runnpm run test:services -- only="myservice"
on Windows.The core fix here is actually:
(basically in #8350 we missed the tests loader).
My original plan was to do that and directly write tests for
loadTesters()
andloadServiceClasses()
but loading all the tester classes with.map(async path => await import(`file://${path}`))
inside anexpect()
was causing some strange side effects with chai, so I decided to separate discovering all the files from loading them and write a test for just making sure we discover the files, which is why there is a bit more refactoring going on in this PR.Side note: This doesn't have any bearing on anything, but I am unreasonably annoyed with myself, windows users, and the world as a whole that I had to install Windows in a VirtualBox in order to work this out when it basically amounted to applying a fix I had already worked out previously without having to do that.