Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default branch #19

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix: update default branch #19

merged 2 commits into from
Oct 27, 2022

Conversation

ohemelaar
Copy link
Contributor

Discourse now uses main as the default branch. Switching from master to main allows updating discourse to newer versions

Newer versions may require fixing permissions on redis' files

Discourse now uses main as the default branch. Switching from master to main allows updating discourse to newer versions

Newer versions may require fixing permissions on redis' files
@badsyntax
Copy link
Owner

badsyntax commented Oct 13, 2022

hi. thanks for the PR and apologies for the belated response.

unfortunately the tests are failing, and i can't debug the tests as i can't create X86_64 vm on my local machine, so i can't verify the change.

are you able to understand why the build is failing? (it might be helpful to view "Raw logs"). it's failing on this test:

@test "should create a new discourse app" {
echo "127.0.0.1 $HOSTNAME" | sudo tee -a /etc/hosts
dokku discourse:create "$APP_NAME" "$HOSTNAME" "$DEVELOPER_EMAILS" "$SMTP_ADDRESS" "$SMTP_PORT" "$SMTP_USER_NAME" "$SMTP_PASSWORD"
grep -qxF "$(dokku apps:list 2> /dev/null)" <<< "$APP_NAME"
# Is discourse actually running?
curl "$HOSTNAME" 2>&1 | grep -q "Discourse Setup"
}

@noeleont
Copy link
Contributor

@badsyntax I had the same error and fixed it in my fork the following way:

digital-sustainability@c432830

@badsyntax
Copy link
Owner

@ohemelaar can you make the change suggested by @noeleont in your branch?

For some, as of today, unknown reason is the output of ./launcher start-cmd
redirected to stderr. Therefore we discard stdout entirely.
@ohemelaar
Copy link
Contributor Author

Hi,
Sorry for forgetting to answer earlier on. I applied the suggested commit.
Thanks

@badsyntax
Copy link
Owner

Test are passing now, thank you very much @noeleont!

@badsyntax badsyntax merged commit fbe03b3 into badsyntax:master Oct 27, 2022
@badsyntax
Copy link
Owner

Released with 0.2.4

use dokku plugin:update discourse to upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants