Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ambiguity on Julia 1.3 #13

Closed
KristofferC opened this issue Sep 5, 2019 · 1 comment
Closed

New ambiguity on Julia 1.3 #13

KristofferC opened this issue Sep 5, 2019 · 1 comment

Comments

@KristofferC
Copy link

While running the package tests for the upcoming 1.3, a new ambiguity in this package was detected:

ERROR: LoadError: LoadError: MethodError: LPVSS(::MultiRBFE{BasisFunctionExpansions.var"##21#25"{Array{Float64,2},Array{Array{Float64,2},1}},Array{Float64,2},Array{Float64,2}}, ::Array{Float64,2}, ::Array{Float64,2}, ::Array{Float64,1}) is ambiguous. Candidates:
  LPVSS(bfe::BasisFunctionExpansion, params, cov, σ) in BasisFunctionExpansions at /root/.julia/packages/BasisFunctionExpansions/tggwO/src/dynamics.jl:81
  LPVSS(x, u, v::Union{AbstractArray{T,1}, AbstractArray{T,2}} where T, nc) in BasisFunctionExpansions at /root/.julia/packages/BasisFunctionExpansions/tggwO/src/dynamics.jl:154
Possible fix, define
  LPVSS(::BasisFunctionExpansion, ::Any, ::Union{AbstractArray{T,1}, AbstractArray{T,2}} where T, ::Any)
Stacktrace:
 [1] #LPVSS#62(::Bool, ::Float64, ::Type{LPVSS}, ::Adjoint{Float64,Array{Float64,2}}, ::Adjoint{Float64,Array{Float64,2}}, ::Int64) at /root/.julia/packages/BasisFunctionExpansions/tggwO/src/dynamics.jl:120
 [2] (::Core.var"#kw#Type")(::NamedTuple{(:normalize, :λ),Tuple{Bool,Float64}}, ::Type{LPVSS}, ::Adjoint{Float64,Array{Float64,2}}, ::Adjoint{Float64,Array{Float64,2}}, ::Int64) at ./none:0
 [3] top-level scope at /root/.julia/packages/BasisFunctionExpansions/tggwO/test/test_LPVSS.jl:25
 [4] include at ./boot.jl:328 [inlined]
 [5] include_relative(::Module, ::String) at ./loading.jl:1105
 [6] include(::Module, ::String) at ./Base.jl:31
 [7] include(::String) at ./client.jl:432
 [8] top-level scope at /root/.julia/packages/BasisFunctionExpansions/tggwO/test/runtests.jl:123
 [9] include at ./boot.jl:328 [inlined]
 [10] include_relative(::Module, ::String) at ./loading.jl:1105
 [11] include(::Module, ::String) at ./Base.jl:31
 [12] include(::String) at ./client.jl:432
 [13] top-level scope at none:6
in expression starting at /root/.julia/packages/BasisFunctionExpansions/tggwO/test/test_LPVSS.jl:25
in expression starting at /root/.julia/packages/BasisFunctionExpansions/tggwO/test/runtests.jl:123

We believe this is a real ambiguity that got detected due to improvements in the Julia type system and thus needs to be fixed in this package.

@KristofferC KristofferC changed the title New ambiguity on 1.3 New ambiguity on Julia 1.3 Sep 20, 2019
@baggepinnen
Copy link
Owner

Fixed :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants