Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded substitution variables from the code #234

Open
sujuka99 opened this issue Jun 7, 2023 · 1 comment
Open

Remove hardcoded substitution variables from the code #234

sujuka99 opened this issue Jun 7, 2023 · 1 comment
Assignees
@sujuka99
Labels
type/refactor Refactoring of existing functionality
Milestone
Hardening KPOps

Comments

@sujuka99
Copy link
Contributor

sujuka99 commented Jun 7, 2023

Solution propositions

  1. Breaking changes (User is responsible to restore the old vars)
    1. Export to os.environ 
      export output_topic_name = "topic_name_config_default_output_topic_name"
export error_topic_name = "topic_name_config_default_error_topic_name"
    2. Solve with YAML
  2. Safe changes
    1. Add new field in the pipeline config, set default value to the hardcoded vars, allow reading from file
@sujuka99 sujuka99 added the type/refactor Refactoring of existing functionality label Jun 7, 2023
@sujuka99 sujuka99 self-assigned this Jun 7, 2023
@sujuka99 sujuka99 mentioned this issue Jun 7, 2023
Merged
@raminqaf raminqaf added this to the Hardening KPOps milestone Jun 8, 2023
@sujuka99 sujuka99 mentioned this issue Nov 3, 2023
Closed
@sujuka99
Copy link
Contributor Author

Idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujuka99 sujuka99

Labels
type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
Hardening KPOps
Development

Successfully merging a pull request may close this issue.

Remove hardcoded substitution variables bakdata/kpops
2 participants
@raminqaf @sujuka99