-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar crash #460
Comments
@tomassatka good hint. Perhaps it might be suffucient to check if the process is running in an interactive terminal. |
@tomassatka How does your config look like? especially how many worker threads do you use? |
I was able to reproduce it in e2e tests. |
My config looks following: i have configmap.yaml apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "kubexporter.name" . }}
data:
config.yaml: |
{{- toYaml .Values.kubexporter.config | nindent 4 }} and then in values.yaml config:
summary: true
progress: simple
archive: false
asLists: false
clearTarget: true
worker: 5
considerOwnerReferences: false
included:
kinds:
- foo.bar.com.Program
- foo.bar.com.Nexus
- foo.bar.com.Gitlab
- xrd.vault.upbound.io.ExternalGroup
- users.nexus.foo.bar.io.User
- roles.nexus.foo.bar.io.Role
- privileges.nexus.foo.bar.io.PrivilegeRepositoryContentSelector
- contentselectors.nexus.foo.bar.io.ContentSelector
- kubernetes.crossplane.io.Object
- groups.gitlab.crossplane.io.Variable
- groups.gitlab.crossplane.io.SamlGroupLink
- groups.gitlab.crossplane.io.Group
- kubernetes.vault.upbound.io.AuthBackendConfig
- kubernetes.vault.upbound.io.AuthBackendRole
- jwt.vault.upbound.io.AuthBackendRole
- jwt.vault.upbound.io.AuthBackend
- auth.vault.upbound.io.Backend
- identity.vault.upbound.io.GroupAlias
- identity.vault.upbound.io.Group
- vault.vault.upbound.io.Mount
- vault.vault.upbound.io.Policy but i had the same behavior with 1 worker as well... |
@tomassatka would you try the latest main image |
hi @bakito Yes it works. Here is the proof where i intentionally put bar as progress and add wrong binding that sa has no access to check the NP from previous issue: config:
summary: true
# progress: simple
progress: bar
archive: false
asLists: false
clearTarget: true
worker: 5
considerOwnerReferences: false
included:
kinds:
- foo.bar.com.Program
- foo.bar.com.Nexus
*
* output with some skipped/masked logs:
looks good when i add
so all works as expected. Waiting for new release that contains it. And a BIG thank you for swift fix. You are helpful as always |
If using binary inside container, when using progress type
bar
the application crash on deadlock.Switching to
simple
solves the issue. But it would be nice that it works out of box since there is also a code that identify that kubexport runs as InCluster() so that could also set the progress to simple.Including crash stack trace when deadlock
The text was updated successfully, but these errors were encountered: