You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
commit fd40b73 added a print() statement to the disconnect function that always outputs "Disconnect request" to stdout. This can break apps using pysyncobj due to excessive log output in interactive use-cases.
Example: Patroni's edit-config feature spawns vi to edit the config values, which gets totally plastered by above message while the config is edited, making the editing almost impossible due to not being able to see what is actually done.
I propose to change the output from print(...) to using python logging (using level DEBUG?) as it is already used in syncobj.py and this seems to be an oversight from implementing/testing.
The text was updated successfully, but these errors were encountered:
Oh, sorry, that was not intended to go to production. Removed that print, updated in pip, please update version to 0.3.10.
I will add a unit-test to avoid adding prints in the future, #154
commit fd40b73 added a print() statement to the disconnect function that always outputs "Disconnect request" to stdout. This can break apps using pysyncobj due to excessive log output in interactive use-cases.
Example: Patroni's edit-config feature spawns vi to edit the config values, which gets totally plastered by above message while the config is edited, making the editing almost impossible due to not being able to see what is actually done.
I propose to change the output from print(...) to using python logging (using level DEBUG?) as it is already used in syncobj.py and this seems to be an oversight from implementing/testing.
The text was updated successfully, but these errors were encountered: