-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite .editorconfig #3474
Comments
Thanks for posting, @udanpe. I'm a repo bot-- nice to meet you! The issue queue in this repo is for verified bugs with documented features. Unfortunately, we can't leave some other types of issues marked as "open". This includes bug reports about undocumented features or unofficial plugins, as well as feature requests, questions, and commentary about the core framework. Please review our contribution guide for details. If you're here looking for help and can't find it, visit StackOverflow, our Google Group or our chat room. But please do not let this disrupt future conversation in this issue! I am only marking it as "closed" to keep organized. Thanks so much for your help!
|
So, you will change [ * ] to [ *.js ] in .editorconfig or we must change this every times when installing new project? Use difference spaces in ejs file not seriously too. Or you afraid that something may break?) |
Directories images js style need rename to img js css because it's standard or images javascripts styles (but if i don't use pluralize it's will look strange) I understand this is not so important but... |
Hey @udanpe, you might want to check out custom generators in Sails. Our docs on the subject aren't great, but Irl has put together a great early in-depth tutorial here. Hope that helps! |
Oh. Robert Martin and Steve Jobs will cry when they see sails I don't want speak more. It makes no sense. Good luck. |
Hi again, @udanpe. From your comment:
I gathered you were suggesting that we change the
re: my suggestion to look into generators: You suggested changing the default directories for images, stylesheets, and client-side JavaScript files in new projects. Unfortunately, I'm not willing to change these things in Sails at this time. One reason is because a large community of developers has become accustomed to this convention for the last few years. I'm not going to get into every reason of why I made the design choices I did in Sails here, but for example, the Sails is a convention over configuration framework: that means that some decisions are made for you by default. You can almost always change these decisions-- and in this case, based on your comments, generators seem like the best fit. Here are a few more examples of the kind of things you can customize:
Generating a model in Sails is a special case of running a generator. Since generators are sometimes useful outside of the context of a Sails app (such as
You're entitled to your opinion, of course, but this is definitely not the opinion of the community at large.
I think we can safely call this addressed in the discussion you and I had here. Please refer to our security policy if you have questions about how we handle these sorts of security issues, or if you have a suspected security vulnerability to report. We also have fairly extensive documentation on security best practices in Sails apps you may want to take a look at. For context, here's an example of a recent potential DoS vulnerability which we were able to quickly address thanks to the community member who reported it, swift efforts of @sgress454 on our core team, and the collaboration of Guillermo Rauch from the Socket.io project.
I'm sorry that you feel this way; but you have to understand that after spending countless hours working on this framework, both over the last year and the past four years; personally, it's hard to take statements like these seriously.
Thank you for taking the time to look into Sails. It's clear we've reached a bit of an impasse here, so at this point, in the interest of time, and to be fair to the other members of the community and our team, I agree that it's time for us both to withdraw from this discussion and get back to work. I hope that you find what you're looking for in another web framework soon, or maybe even take a stab at putting together your own project-- it can be a great learning experience. In any case, I sincerely wish you the best. |
Change [ * ] to [ *.js ] in .editorconfig
2 space: 403.ejs 404.ejs 500.ejs
4 space: homepage.ejs layout.ejs
Maybe write for [ *.ejs ] too?
The text was updated successfully, but these errors were encountered: