Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests calling the Sails binary directly fail on Windows #3482

Closed
sgress454 opened this issue Jan 11, 2016 · 0 comments · Fixed by #3484
Closed

Tests calling the Sails binary directly fail on Windows #3482

sgress454 opened this issue Jan 11, 2016 · 0 comments · Fixed by #3484
Assignees

Comments

@sgress454
Copy link
Member

Originally from #3466 (comment)

Calls like exec(sailsBin + ' new ' + appName, ...) where sailsBin is './bin/sails.js' fail on Windows due to the use of the forward slash, as well as the inconsistent association of .js files with the Node executable (the shebang a the top of sails.js obviously doesn't work on Windows).

Probably best to replace exec with a fork call, since it uses the Node binary implicitly. Then we don't have to worry about the .js association. The path problem can be fixed by just using path.sep or path.resolve().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant