Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of prompt to 1.2.1 to get rid of rogue colors package #7201

Closed
dhwaneetbhatt opened this issue Jan 10, 2022 · 2 comments · May be fixed by FalconSocial/frontend-assignment#22
Labels

Comments

@dhwaneetbhatt
Copy link
Contributor

dhwaneetbhatt commented Jan 10, 2022

Node version: 10.14.1
Sails version (sails): 1.5.0
ORM hook version (sails-hook-orm): 3.0.2
Sockets hook version (sails-hook-sockets): N.A.
Organics hook version (sails-hook-organics): N.A.
Grunt hook version (sails-hook-grunt): N.A.
Uploads hook version (sails-hook-uploads): N.A.
DB adapter & version (e.g. sails-mysql@5.55.5): N.A
Skipper adapter & version (e.g. skipper-s3@5.55.5): N.A


Please upgrade to v1.2.1 for Prompt: flatiron/prompt@b554b31

It pinned colors dependency to 1.4.0.

Issue: The author of https://github.com/Marak/colors.js has pushed a rogue commit on the newest version which causes garbage to be printed in the console and an infinite loop.

News: https://snyk.io/blog/open-source-npm-packages-colors-faker/

I have raised a PR for this: #7202

@sailsbot
Copy link

@dhwaneetbhatt Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@dhwaneetbhatt dhwaneetbhatt changed the title t Upgrade version of prompt to 1.2.1 to get rid of rogue colors package Jan 10, 2022
@eashaw
Copy link
Member

eashaw commented Jan 14, 2022

Thank you @dhwaneetbhatt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants