Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moment.js #1219

Closed
maggie44 opened this issue Apr 23, 2022 · 2 comments · Fixed by #1265
Closed

Remove moment.js #1219

maggie44 opened this issue Apr 23, 2022 · 2 comments · Fixed by #1265

Comments

@maggie44
Copy link

maggie44 commented Apr 23, 2022

Moment.js is largely deprecated. It's own README included in the installed package states:

## Project Status

Moment.js is a legacy project, now in maintenance mode.  In most cases, you should choose a different library.

For more details and recommendations, please see [Project Status](https://momentjs.com/docs/#/-project-status/) in the docs.

It looks like in the SDK it is only used here: https://github.com/balena-io/balena-sdk/blob/master/lib/util/date.ts

It would be nice to switch to something else, because the Balena SDK is already the largest node_module in my projects, followed only by moment:

Screenshot 2022-04-23 at 20 28 25

When size matters, catching these low hanging fruit makes a difference.


yarn why moment
└─ balena-sdk@npm:16.19.7
   └─ moment@npm:2.29.2 (via npm:^2.29.1)
@thgreasi
Copy link
Member

Thanks for raising this. I will pass this internally and prioritize accordingly.

@thgreasi thgreasi linked a pull request Jul 25, 2023 that will close this issue
4 tasks
@thgreasi
Copy link
Member

Resolved by #1265 in v16.26.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants