Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(Validators): BalValidators seem not to follow the Angular standard #60

Open
1 task done
hirsch88 opened this issue Jul 4, 2023 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@hirsch88
Copy link
Member

hirsch88 commented Jul 4, 2023

Current Behavior

Hi guys,

it seems like the BalValidators don't follow the Angular standard because the return of the ValidatorFunction needs to be {[key: string]: boolean} | null (ValidationErrors | null) and they only return a boolean. I don't know if I don't use them correctly?

Expected Behavior

Validation needs to work

Steps to Reproduce

  1. Register a form-control in a form with BalValidators attached
  2. Set the form control to an invalid state
  3. Check the valid property of the containing formGroup

Version

13.0.0

Browsers

Firefox, Chrome, Safari, Microsoft Edge

Device

Desktop

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant