From 179acd12d1420792bbfcfabc02d22150af38704c Mon Sep 17 00:00:00 2001 From: "lane.wei" Date: Mon, 17 Jun 2024 20:21:13 +0800 Subject: [PATCH 1/9] ENH: CLI: add logic to save metadata into 3mf from CLI JIRA: no jira Change-Id: I7f96c2ab9671ec1c0115e90f6d64230b8170eb38 (cherry picked from commit 3d2d6e23ba318a2b331a62e320f8ca199168f1f5) --- src/BambuStudio.cpp | 21 +++++++++++++++++++++ src/libslic3r/Format/bbs_3mf.cpp | 7 +++++++ src/libslic3r/Model.cpp | 8 +++++++- src/libslic3r/Model.hpp | 4 +++- src/libslic3r/PrintConfig.cpp | 12 ++++++++++++ 5 files changed, 50 insertions(+), 2 deletions(-) diff --git a/src/BambuStudio.cpp b/src/BambuStudio.cpp index 0b0ac8223a..7558048d00 100644 --- a/src/BambuStudio.cpp +++ b/src/BambuStudio.cpp @@ -1223,6 +1223,15 @@ int CLI::run(int argc, char **argv) DynamicPrintConfig load_process_config, load_machine_config; bool new_process_config_is_system = true, new_printer_config_is_system = true; std::string pipe_name, makerlab_name, makerlab_version, different_process_setting; + const std::vector &metadata_name = m_config.option("metadata_name", true)->values; + const std::vector &metadata_value = m_config.option("metadata_value", true)->values; + + if (metadata_name.size() != metadata_value.size()) + { + BOOST_LOG_TRIVIAL(error) << boost::format("metadata_name should be the same size with metadata_value"); + record_exit_reson(outfile_dir, CLI_INVALID_PARAMS, 0, cli_errors[CLI_INVALID_PARAMS], sliced_info); + flush_and_exit(CLI_INVALID_PARAMS); + } // Read input file(s) if any. BOOST_LOG_TRIVIAL(info) << "Will start to read model file now, file count :" << m_input_files.size() << "\n"; @@ -5863,6 +5872,18 @@ int CLI::run(int argc, char **argv) model.mk_version = makerlab_version; BOOST_LOG_TRIVIAL(info) << boost::format("mk_name %1%, mk_version %2%")%makerlab_name %makerlab_version; } + + if (!metadata_name.empty()) { + Model &model = m_models[0]; + + model.md_value = metadata_value; + model.md_name = metadata_name; + for (unsigned int i = 0; i < metadata_name.size(); i++) + { + BOOST_LOG_TRIVIAL(info) << boost::format("index %1% metadata_name %2%, metadata_value %3%")%i %metadata_name[i] %metadata_value[i]; + } + } + if (!this->export_project(&m_models[0], export_3mf_file, plate_data_list, project_presets, thumbnails, no_light_thumbnails, top_thumbnails, pick_thumbnails, calibration_thumbnails, plate_bboxes, &m_print_config, minimum_save, plate_to_slice - 1)) { diff --git a/src/libslic3r/Format/bbs_3mf.cpp b/src/libslic3r/Format/bbs_3mf.cpp index e7269b0197..ca2043e1f0 100644 --- a/src/libslic3r/Format/bbs_3mf.cpp +++ b/src/libslic3r/Format/bbs_3mf.cpp @@ -6250,6 +6250,13 @@ void PlateData::parse_filament_info(GCodeProcessorResult *result) metadata_item_map[BBL_MAKERLAB_VERSION_TAG] = xml_escape(model.mk_version); BOOST_LOG_TRIVIAL(info) << "saved mk_version " << model.mk_version; } + if (!model.md_name.empty()) { + for (unsigned int i = 0; i < model.md_name.size(); i++) + { + BOOST_LOG_TRIVIAL(info) << boost::format("saved metadata_name %1%, metadata_value %2%") %model.md_name[i] %model.md_value[i]; + metadata_item_map[model.md_name[i]] = xml_escape(model.md_value[i]); + } + } // store metadata info for (auto item : metadata_item_map) { diff --git a/src/libslic3r/Model.cpp b/src/libslic3r/Model.cpp index eb376e6fc3..be893e0407 100644 --- a/src/libslic3r/Model.cpp +++ b/src/libslic3r/Model.cpp @@ -92,6 +92,8 @@ Model& Model::assign_copy(const Model &rhs) this->mk_name = rhs.mk_name; this->mk_version = rhs.mk_version; + this->md_name = rhs.md_name; + this->md_value = rhs.md_value; return *this; } @@ -124,6 +126,8 @@ Model& Model::assign_copy(Model &&rhs) this->stl_design_country = rhs.stl_design_country; this->mk_name = rhs.mk_name; this->mk_version = rhs.mk_version; + this->md_name = rhs.md_name; + this->md_value = rhs.md_value; this->backup_path = std::move(rhs.backup_path); this->object_backup_id_map = std::move(rhs.object_backup_id_map); this->next_object_backup_id = rhs.next_object_backup_id; @@ -962,6 +966,8 @@ void Model::load_from(Model& model) profile_info = model.profile_info; mk_name = model.mk_name; mk_version = model.mk_version; + md_name = model.md_name; + md_value = model.md_value; model.design_info.reset(); model.model_info.reset(); model.profile_info.reset(); @@ -3497,7 +3503,7 @@ bool Model::obj_import_vertex_color_deal(const std::vector &verte case _3_SAME_COLOR: { std::string result; get_real_filament_id(filament_id0, result); - volume->mmu_segmentation_facets.set_triangle_from_string(i, result); + volume->mmu_segmentation_facets.set_triangle_from_string(i, result); break; } case _3_DIFF_COLOR: { diff --git a/src/libslic3r/Model.hpp b/src/libslic3r/Model.hpp index e484fb024e..02dbdce8cd 100644 --- a/src/libslic3r/Model.hpp +++ b/src/libslic3r/Model.hpp @@ -413,7 +413,7 @@ class ModelObject final : public ObjectBase bool is_mm_painted() const; // This object may have a varying layer height by painting or by a table. // Even if true is returned, the layer height profile may be "flat" with no difference to default layering. - bool has_custom_layering() const + bool has_custom_layering() const { return ! this->layer_config_ranges.empty() || ! this->layer_height_profile.empty(); } ModelInstance* add_instance(); @@ -1525,6 +1525,8 @@ class Model final : public ObjectBase //makerlab information std::string mk_name; std::string mk_version; + std::vector md_name; + std::vector md_value; void SetDesigner(std::string designer, std::string designer_user_id) { if (design_info == nullptr) { diff --git a/src/libslic3r/PrintConfig.cpp b/src/libslic3r/PrintConfig.cpp index adb4aa3cd3..425fda9414 100644 --- a/src/libslic3r/PrintConfig.cpp +++ b/src/libslic3r/PrintConfig.cpp @@ -5803,6 +5803,18 @@ CLIMiscConfigDef::CLIMiscConfigDef() def->cli_params = "version"; def->set_default_value(new ConfigOptionString()); + def = this->add("metadata_name", coStrings); + def->label = "metadata name list"; + def->tooltip = "matadata name list added into 3mf"; + def->cli_params = "\"name1;name2;...\""; + def->set_default_value(new ConfigOptionStrings()); + + def = this->add("metadata_value", coStrings); + def->label = "metadata value list"; + def->tooltip = "matadata value list added into 3mf"; + def->cli_params = "\"value1;value2;...\""; + def->set_default_value(new ConfigOptionStrings()); + def = this->add("allow_newer_file", coBool); def->label = "Allow 3mf with newer version to be sliced"; def->tooltip = "Allow 3mf with newer version to be sliced"; From 57e7714bfb772f2cdba9ecf2eeabd42d113a714b Mon Sep 17 00:00:00 2001 From: Mack Date: Fri, 7 Jun 2024 18:21:04 +0800 Subject: [PATCH 2/9] ci: support vs2022 17.1x.y JIRA: STUDIO-6329 Change-Id: I788b6967a31a79542410e16a3d8bae2b53c24553 --- deps/Boost/Boost.cmake | 4 +-- deps/OpenCV/0001-OpenCV-fix.patch | 52 +++++++++++++++++++++++++++++++ deps/OpenCV/OpenCV.cmake | 1 + deps/OpenSSL/OpenSSL.cmake | 16 +++++----- deps/deps-windows.cmake | 5 +-- 5 files changed, 67 insertions(+), 11 deletions(-) create mode 100644 deps/OpenCV/0001-OpenCV-fix.patch diff --git a/deps/Boost/Boost.cmake b/deps/Boost/Boost.cmake index bdf775daf6..5d3703016b 100644 --- a/deps/Boost/Boost.cmake +++ b/deps/Boost/Boost.cmake @@ -26,8 +26,8 @@ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") elseif (MSVC_VERSION LESS 1930) # 1920-1929 = VS 16.0 (v142 toolset) set(_boost_toolset "msvc-14.2") - elseif (MSVC_VERSION LESS 1940) - # 1930-1939 = VS 17.0 (v143 toolset) + elseif (MSVC_VERSION LESS 1950) + # 1930-1949 = VS 17.0 (v143 toolset) set(_boost_toolset "msvc-14.3") else () message(FATAL_ERROR "Unsupported MSVC version") diff --git a/deps/OpenCV/0001-OpenCV-fix.patch b/deps/OpenCV/0001-OpenCV-fix.patch new file mode 100644 index 0000000000..6e5aba84e8 --- /dev/null +++ b/deps/OpenCV/0001-OpenCV-fix.patch @@ -0,0 +1,52 @@ +From 6fb3f6333150a777e835fc7c48e49750591bf7fe Mon Sep 17 00:00:00 2001 +From: Benjamin Buch +Date: Thu, 23 May 2024 16:05:19 +0200 +Subject: [PATCH] Support VS 2022 17.1x.y + +With 17.10.0 the MSVC toolset was set to 19.40.x which breaks the compatibility test in the OpenCV's CMake Config files. +--- + cmake/templates/OpenCVConfig.root-WIN32.cmake.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/cmake/templates/OpenCVConfig.root-WIN32.cmake.in b/cmake/templates/OpenCVConfig.root-WIN32.cmake.in +index b0f254ebe8..62e36272f3 100644 +--- a/cmake/templates/OpenCVConfig.root-WIN32.cmake.in ++++ b/cmake/templates/OpenCVConfig.root-WIN32.cmake.in +@@ -137,7 +137,7 @@ elseif(MSVC) + set(OpenCV_RUNTIME vc14) # selecting previous compatible runtime version + endif() + endif() +- elseif(MSVC_VERSION MATCHES "^193[0-9]$") ++ elseif(MSVC_VERSION MATCHES "^19[34][0-9]$") + set(OpenCV_RUNTIME vc17) + check_one_config(has_VS2022) + if(NOT has_VS2022) +-- +2.45.2.windows.1 + +From f85818ba6f9031c450475a7453dee0acce31a881 Mon Sep 17 00:00:00 2001 +From: Benjamin Buch +Date: Fri, 24 May 2024 11:10:09 +0200 +Subject: [PATCH] Support VS 2022 17.1x.y in OpenCVDetectCXXCompiler.cmake + +With 17.10.0 the MSVC toolset was set to 19.40.x which breaks the compatibility test in the OpenCV's CMake Config files. +--- + cmake/OpenCVDetectCXXCompiler.cmake | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/cmake/OpenCVDetectCXXCompiler.cmake b/cmake/OpenCVDetectCXXCompiler.cmake +index 1743aca11f..448afd46ea 100644 +--- a/cmake/OpenCVDetectCXXCompiler.cmake ++++ b/cmake/OpenCVDetectCXXCompiler.cmake +@@ -176,7 +176,7 @@ elseif(MSVC) + set(OpenCV_RUNTIME vc15) + elseif(MSVC_VERSION MATCHES "^192[0-9]$") + set(OpenCV_RUNTIME vc16) +- elseif(MSVC_VERSION MATCHES "^193[0-9]$") ++ elseif(MSVC_VERSION MATCHES "^19[34][0-9]$") + set(OpenCV_RUNTIME vc17) + else() + message(WARNING "OpenCV does not recognize MSVC_VERSION \"${MSVC_VERSION}\". Cannot set OpenCV_RUNTIME") +-- +2.45.2.windows.1 + diff --git a/deps/OpenCV/OpenCV.cmake b/deps/OpenCV/OpenCV.cmake index e9f409353a..f99b8500db 100644 --- a/deps/OpenCV/OpenCV.cmake +++ b/deps/OpenCV/OpenCV.cmake @@ -7,6 +7,7 @@ endif () bambustudio_add_cmake_project(OpenCV URL https://github.com/opencv/opencv/archive/refs/tags/4.6.0.tar.gz URL_HASH SHA256=1ec1cba65f9f20fe5a41fda1586e01c70ea0c9a6d7b67c9e13edf0cfe2239277 + PATCH_COMMAND git apply --directory deps/build/dep_OpenCV-prefix/src/dep_OpenCV --verbose --ignore-space-change --whitespace=fix ${CMAKE_CURRENT_LIST_DIR}/0001-OpenCV-fix.patch CMAKE_ARGS -DBUILD_SHARED_LIBS=0 -DBUILD_PERE_TESTS=OFF diff --git a/deps/OpenSSL/OpenSSL.cmake b/deps/OpenSSL/OpenSSL.cmake index 766b3eb5af..32e0a3159f 100644 --- a/deps/OpenSSL/OpenSSL.cmake +++ b/deps/OpenSSL/OpenSSL.cmake @@ -38,13 +38,15 @@ else() endif () endif() -if(CMAKE_SYSTEM_NAME STREQUAL "Linux") -set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1k.tar.gz") -set(url_hash "SHA256=b92f9d3d12043c02860e5e602e50a73ed21a69947bcc74d391f41148e9f6aa95") -else() -set(url_str "https://github.com/openssl/openssl/archive/refs/tags/openssl-3.1.2.tar.gz") -set(url_hash "SHA256=8c776993154652d0bb393f506d850b811517c8bd8d24b1008aef57fbe55d3f31") -endif() +# if(CMAKE_SYSTEM_NAME STREQUAL "Linux") +# set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1k.tar.gz") +# set(url_hash "SHA256=b92f9d3d12043c02860e5e602e50a73ed21a69947bcc74d391f41148e9f6aa95") +# else() +# set(url_str "https://github.com/openssl/openssl/archive/refs/tags/openssl-3.1.2.tar.gz") +# set(url_hash "SHA256=8c776993154652d0bb393f506d850b811517c8bd8d24b1008aef57fbe55d3f31") +# endif() +set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1w.tar.gz") +set(url_hash "SHA256=2130E8C2FB3B79D1086186F78E59E8BC8D1A6AEDF17AB3907F4CB9AE20918C41") ExternalProject_Add(dep_OpenSSL #EXCLUDE_FROM_ALL ON URL ${url_str} diff --git a/deps/deps-windows.cmake b/deps/deps-windows.cmake index aba6fcab49..f0a972d902 100644 --- a/deps/deps-windows.cmake +++ b/deps/deps-windows.cmake @@ -1,4 +1,5 @@ # https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html +message(STATUS "MSVC_VERSION: ${MSVC_VERSION}") if (MSVC_VERSION EQUAL 1800) # 1800 = VS 12.0 (v120 toolset) set(DEP_VS_VER "12") @@ -15,8 +16,8 @@ elseif (MSVC_VERSION LESS 1930) # 1920-1929 = VS 16.0 (v142 toolset) set(DEP_VS_VER "16") set(DEP_BOOST_TOOLSET "msvc-14.2") -elseif (MSVC_VERSION LESS 1940) -# 1930-1939 = VS 17.0 (v143 toolset) +elseif (MSVC_VERSION LESS 1950) +# 1930-1949 = VS 17.0 (v143 toolset) set(DEP_VS_VER "17") set(DEP_BOOST_TOOLSET "msvc-14.3") else () From 1acea099e75c6ebe0871f53697144ebbc3157d3c Mon Sep 17 00:00:00 2001 From: Mack Date: Mon, 10 Jun 2024 03:33:29 +0800 Subject: [PATCH 3/9] ci: unstable download of OSSPlanet freetype files JIRA: STUDIO-6329 Change-Id: Ia8ee9eb723aaff3bb91e81e0a838847cde664894 --- deps/FREETYPE/FREETYPE.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/deps/FREETYPE/FREETYPE.cmake b/deps/FREETYPE/FREETYPE.cmake index 714df28cff..d4b5e0811b 100644 --- a/deps/FREETYPE/FREETYPE.cmake +++ b/deps/FREETYPE/FREETYPE.cmake @@ -11,8 +11,8 @@ else() endif() bambustudio_add_cmake_project(FREETYPE - URL https://mirror.ossplanet.net/nongnu/freetype/freetype-2.12.1.tar.gz - URL_HASH SHA256=efe71fd4b8246f1b0b1b9bfca13cfff1c9ad85930340c27df469733bbb620938 + URL https://github.com/freetype/freetype/archive/refs/tags/VER-2-12-1.tar.gz + URL_HASH SHA256=0E72CAE32751598D126CFD4BCEDA909F646B7231AB8C52E28ABB686C20A2BEA1 #DEPENDS ${ZLIB_PKG} #"${_patch_step}" CMAKE_ARGS From d30fb51b8599b81031db22360d66f9f82d5fb79b Mon Sep 17 00:00:00 2001 From: Mack Date: Thu, 13 Jun 2024 18:45:46 +0800 Subject: [PATCH 4/9] ci: github actions add ubuntu24 build JIRA: STUDIO-6329 Change-Id: I499d21a1ae61ece2a753a71de621dc7e86fc921d --- .github/workflows/build_all.yml | 1 + .github/workflows/build_bambu.yml | 18 +++++++++--------- .github/workflows/build_check_cache.yml | 2 +- .github/workflows/build_deps.yml | 14 +++++++------- BuildLinux.sh | 25 +++++++++++++++++-------- 5 files changed, 35 insertions(+), 25 deletions(-) diff --git a/.github/workflows/build_all.yml b/.github/workflows/build_all.yml index bea8746c57..e91326282e 100644 --- a/.github/workflows/build_all.yml +++ b/.github/workflows/build_all.yml @@ -44,6 +44,7 @@ jobs: matrix: include: - os: ubuntu-20.04 + - os: ubuntu-24.04 - os: windows-latest - os: macos-13 arch: x86_64 diff --git a/.github/workflows/build_bambu.yml b/.github/workflows/build_bambu.yml index 05c34df287..74cdae2ff8 100644 --- a/.github/workflows/build_bambu.yml +++ b/.github/workflows/build_bambu.yml @@ -225,28 +225,28 @@ jobs: # Ubuntu - name: Install dependencies - if: inputs.os == 'ubuntu-20.04' + if: inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04' run: | sudo apt-get update sudo apt-get install -y autoconf build-essential cmake curl wget file git \ libgl1-mesa-dev libgtk-3-dev libxkbcommon-dev libunwind-dev libfuse2 - name: Install dependencies from BuildLinux.sh - if: inputs.os == 'ubuntu-20.04' + if: inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04' shell: bash run: sudo ./BuildLinux.sh -ur - name: Fix permissions - if: inputs.os == 'ubuntu-20.04' + if: inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04' shell: bash run: sudo chown $USER -R ./ - name: Build slicer - if: inputs.os == 'ubuntu-20.04' + if: inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04' shell: bash run: | ./BuildLinux.sh -isr - mv -n ./build/BambuStudio_ubu64.AppImage ./build/Bambu_Studio_linux_${{ env.ver }}.AppImage + mv -n ./build/BambuStudio_ubu64.AppImage ./build/Bambu_Studio_${{inputs.os}}_${{ env.ver }}.AppImage # - name: Build orca_custom_preset_tests # if: github.ref == 'refs/heads/main' && inputs.os == 'ubuntu-20.04' @@ -258,11 +258,11 @@ jobs: # zip -r orca_custom_preset_tests.zip user/ - name: Upload artifacts Ubuntu - if: ${{ ! env.ACT && inputs.os == 'ubuntu-20.04' }} + if: ${{ ! env.ACT && (inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04') }} uses: actions/upload-artifact@v4 with: - name: BambuStudio_Linux_${{ env.ver }} - path: './build/Bambu_Studio_linux_${{ env.ver }}.AppImage' + name: BambuStudio_${{inputs.os}}_${{ env.ver }} + path: './build/Bambu_Studio_${{inputs.os}}_${{ env.ver }}.AppImage' # - name: Deploy Ubuntu release # if: ${{ ! env.ACT && github.ref == 'refs/heads/main' && inputs.os == 'ubuntu-20.04' }} @@ -284,4 +284,4 @@ jobs: # asset_path: ${{ github.workspace }}/resources/profiles/orca_custom_preset_tests.zip # asset_name: orca_custom_preset_tests.zip # asset_content_type: application/octet-stream - # max_releases: 1 \ No newline at end of file + # max_releases: 1 diff --git a/.github/workflows/build_check_cache.yml b/.github/workflows/build_check_cache.yml index 4ac7783b1b..3fbf635bf0 100644 --- a/.github/workflows/build_check_cache.yml +++ b/.github/workflows/build_check_cache.yml @@ -35,7 +35,7 @@ jobs: dep-folder-name: ${{ (inputs.os == 'windows-latest' || inputs.os == 'macos-13') && 'BambuStudio_dep' || 'destdir' }} output-cmd: ${{ inputs.os == 'windows-latest' && '$env:GITHUB_OUTPUT' || '"$GITHUB_OUTPUT"'}} run: | - echo cache-key=${{ runner.os }}${{ env.dash-arch }}-cache-bambustudio_deps-build-${{ hashFiles('deps/**') }} >> ${{ env.output-cmd }} + echo cache-key=${{ inputs.os }}${{ env.dash-arch }}-cache-bambustudio_deps-build-${{ hashFiles('deps/**') }} >> ${{ env.output-cmd }} echo cache-path=${{ github.workspace }}/deps/build${{ env.underscore-arch }}/${{ env.dep-folder-name }}${{ env.underscore-arch }} >> ${{ env.output-cmd }} - name: load cache diff --git a/.github/workflows/build_deps.yml b/.github/workflows/build_deps.yml index 4b6ee58657..d6f861d73d 100644 --- a/.github/workflows/build_deps.yml +++ b/.github/workflows/build_deps.yml @@ -90,18 +90,18 @@ jobs: - name: Build on Ubuntu - if: inputs.os == 'ubuntu-20.04' + if: inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04' working-directory: ${{ github.workspace }} run: | sudo apt-get update - sudo apt-get install cmake libgl1-mesa-dev libgtk-3-dev libxkbcommon-dev libunwind-dev libfuse2 -y + sudo apt-get install libgl1-mesa-dev libgtk-3-dev libxkbcommon-dev libunwind-dev libfuse2 -y mkdir -p ${{ github.workspace }}/deps/build mkdir -p ${{ github.workspace }}/deps/build/destdir sudo ./BuildLinux.sh -ur sudo chown $USER -R ./ ./BuildLinux.sh -dr cd deps/build - tar -czvf BambuStudio_dep_ubuntu_$(date +"%Y%m%d").tar.gz destdir + tar -czvf BambuStudio_dep_${{ inputs.os }}_$(date +"%Y%m%d").tar.gz destdir # Upload Artifacts @@ -120,11 +120,11 @@ jobs: path: ${{ github.workspace }}/deps/build/BambuStudio_dep*.zip - name: Upload Ubuntu artifacts - if: ${{ ! env.ACT && inputs.os == 'ubuntu-20.04' }} + if: ${{ ! env.ACT && (inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04') }} uses: actions/upload-artifact@v4 with: - name: BambuStudio_dep_ubuntu_${{ env.date }} - path: ${{ github.workspace }}/deps/build/BambuStudio_dep_ubuntu_*.tar.gz + name: BambuStudio_dep_${{ inputs.os }}_${{ env.date }} + path: ${{ github.workspace }}/deps/build/BambuStudio_dep_${{ inputs.os }}_*.tar.gz build_Bambu: name: Build BambuStudio @@ -136,4 +136,4 @@ jobs: cache-path: ${{ inputs.cache-path }} os: ${{ inputs.os }} arch: ${{ inputs.arch }} - secrets: inherit \ No newline at end of file + secrets: inherit diff --git a/BuildLinux.sh b/BuildLinux.sh index 5be61155eb..2496a2ac9d 100755 --- a/BuildLinux.sh +++ b/BuildLinux.sh @@ -87,14 +87,6 @@ then mkdir build fi -# Addtional Dev packages for BambuStudio -export REQUIRED_DEV_PACKAGES="libgstreamerd-3-dev libsecret-1-dev libwebkit2gtk-4.0-dev libosmesa6-dev libssl-dev libcurl4-openssl-dev eglexternalplatform-dev libudev-dev libdbus-1-dev extra-cmake-modules" -# libwebkit2gtk-4.1-dev ?? -export DEV_PACKAGES_COUNT=$(echo ${REQUIRED_DEV_PACKAGES} | wc -w) -if [ $(dpkg --get-selections | grep -E "$(echo ${REQUIRED_DEV_PACKAGES} | tr ' ' '|')" | wc -l) -lt ${DEV_PACKAGES_COUNT} ]; then - sudo apt install -y ${REQUIRED_DEV_PACKAGES} git cmake wget file -fi - #FIXME: require root for -u option if [[ -n "$UPDATE_LIB" ]] then @@ -114,12 +106,29 @@ then if [[ $ubu_version == "Ubuntu 22.04"* ]] then apt install -y curl libssl-dev libcurl4-openssl-dev m4 + elif [[ $ubu_version == "Ubuntu 24.04"* ]] + then + NEW_SOURCE="deb http://gb.archive.ubuntu.com/ubuntu jammy main" + if grep -qF -- "$NEW_SOURCE" /etc/apt/sources.list; then + echo "source exist: $NEW_SOURCE" + else + echo "$NEW_SOURCE" | sudo tee -a /etc/apt/sources.list > /dev/null + fi + apt update fi if [[ -n "$BUILD_DEBUG" ]] then echo -e "\nInstalling: libssl-dev libcurl4-openssl-dev\n" apt install -y libssl-dev libcurl4-openssl-dev fi + + # Addtional Dev packages for BambuStudio + export REQUIRED_DEV_PACKAGES="libgstreamerd-3-dev libsecret-1-dev libwebkit2gtk-4.0-dev libosmesa6-dev libssl-dev libcurl4-openssl-dev eglexternalplatform-dev libudev-dev libdbus-1-dev extra-cmake-modules" + # libwebkit2gtk-4.1-dev ?? + export DEV_PACKAGES_COUNT=$(echo ${REQUIRED_DEV_PACKAGES} | wc -w) + if [ $(dpkg --get-selections | grep -E "$(echo ${REQUIRED_DEV_PACKAGES} | tr ' ' '|')" | wc -l) -lt ${DEV_PACKAGES_COUNT} ]; then + sudo apt install -y ${REQUIRED_DEV_PACKAGES} git cmake wget file + fi echo -e "done\n" exit 0 fi From 5c6c68e051d24d0bded596b93aa68d40adcd4d81 Mon Sep 17 00:00:00 2001 From: Mack Date: Tue, 18 Jun 2024 11:38:55 +0800 Subject: [PATCH 5/9] ci: update openssl version 3.1.2 JIRA: STUDIO-6329 Change-Id: Ic4e6a02e7077579fb540e408d635ba890a779a48 --- deps/OpenSSL/OpenSSL.cmake | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/deps/OpenSSL/OpenSSL.cmake b/deps/OpenSSL/OpenSSL.cmake index 32e0a3159f..4794e2cfc3 100644 --- a/deps/OpenSSL/OpenSSL.cmake +++ b/deps/OpenSSL/OpenSSL.cmake @@ -38,15 +38,15 @@ else() endif () endif() -# if(CMAKE_SYSTEM_NAME STREQUAL "Linux") -# set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1k.tar.gz") -# set(url_hash "SHA256=b92f9d3d12043c02860e5e602e50a73ed21a69947bcc74d391f41148e9f6aa95") -# else() -# set(url_str "https://github.com/openssl/openssl/archive/refs/tags/openssl-3.1.2.tar.gz") -# set(url_hash "SHA256=8c776993154652d0bb393f506d850b811517c8bd8d24b1008aef57fbe55d3f31") -# endif() -set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1w.tar.gz") -set(url_hash "SHA256=2130E8C2FB3B79D1086186F78E59E8BC8D1A6AEDF17AB3907F4CB9AE20918C41") +if(CMAKE_SYSTEM_NAME STREQUAL "Linux") +set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1k.tar.gz") +set(url_hash "SHA256=b92f9d3d12043c02860e5e602e50a73ed21a69947bcc74d391f41148e9f6aa95") +else() +set(url_str "https://github.com/openssl/openssl/archive/refs/tags/openssl-3.1.2.tar.gz") +set(url_hash "SHA256=8c776993154652d0bb393f506d850b811517c8bd8d24b1008aef57fbe55d3f31") +endif() +# set(url_str "https://github.com/openssl/openssl/archive/OpenSSL_1_1_1w.tar.gz") +# set(url_hash "SHA256=2130E8C2FB3B79D1086186F78E59E8BC8D1A6AEDF17AB3907F4CB9AE20918C41") ExternalProject_Add(dep_OpenSSL #EXCLUDE_FROM_ALL ON URL ${url_str} From b0c40dbb58f49e2e7477d875d6204b0e09e35478 Mon Sep 17 00:00:00 2001 From: Mack Date: Sun, 16 Jun 2024 14:30:50 +0800 Subject: [PATCH 6/9] ci: pack macos dep JIRA: STUDIO-6329 Change-Id: Id58ad01e9b5113fd306345068bb3b3088fbab75a --- .github/workflows/build_bambu.yml | 2 +- .github/workflows/build_deps.yml | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_bambu.yml b/.github/workflows/build_bambu.yml index 74cdae2ff8..194bb774f1 100644 --- a/.github/workflows/build_bambu.yml +++ b/.github/workflows/build_bambu.yml @@ -78,7 +78,7 @@ jobs: if: inputs.os == 'macos-13' working-directory: ${{ github.workspace }} run: | - brew install cmake git gettext automake texinfo + brew install automake texinfo mkdir -p ${{ github.workspace }}/build_${{inputs.arch}} cd ${{ github.workspace }}/build_${{inputs.arch}} cmake .. -DBBL_RELEASE_TO_PUBLIC=1 -DCMAKE_PREFIX_PATH="${{ github.workspace }}/deps/build_${{ inputs.arch }}/BambuStudio_dep_${{ inputs.arch }}/usr/local" -DCMAKE_INSTALL_PREFIX="../install_dir" -DCMAKE_BUILD_TYPE=Release -DCMAKE_MACOSX_RPATH=ON -DCMAKE_INSTALL_RPATH="${{ github.workspace }}/deps/build_${{ inputs.arch }}/BambuStudio_dep_${{ inputs.arch }}/usr/local" -DCMAKE_MACOSX_BUNDLE=on diff --git a/.github/workflows/build_deps.yml b/.github/workflows/build_deps.yml index d6f861d73d..d4ead356b8 100644 --- a/.github/workflows/build_deps.yml +++ b/.github/workflows/build_deps.yml @@ -79,7 +79,7 @@ jobs: if: inputs.os == 'macos-13' working-directory: ${{ github.workspace }} run: | - brew install cmake git gettext automake texinfo + brew install automake texinfo brew uninstall --ignore-dependencies zstd mkdir -p ${{ github.workspace }}/deps/build_${{ inputs.arch }} mkdir -p ${{ github.workspace }}/deps/build_${{ inputs.arch }}/BambuStudio_dep_${{ inputs.arch }} @@ -88,6 +88,11 @@ jobs: make -j4 brew install zstd + - name: pack deps on Macos + if: inputs.os == 'macos-13' + working-directory: ${{ github.workspace }} + run: tar -zcvf "BambuStudio_dep_mac_${{ inputs.arch }}_$(date +"%Y%m%d").tar.gz" "${{ github.workspace }}/deps/build_${{ inputs.arch }}/BambuStudio_dep_${{ inputs.arch }}" + - name: Build on Ubuntu if: inputs.os == 'ubuntu-20.04' || inputs.os == 'ubuntu-24.04' @@ -110,7 +115,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: BambuStudio_dep_mac_${{ inputs.arch }}_${{ env.date }} - path: ${{ github.workspace }}/deps/build_${{ inputs.arch }}/BambuStudio_dep*.tar.gz + path: ${{ github.workspace }}/BambuStudio_dep_mac_${{ inputs.arch }}*.tar.gz - name: Upload Windows artifacts if: inputs.os == 'windows-latest' From c8378296fa42836408dceb877452b7d4aa32c1f6 Mon Sep 17 00:00:00 2001 From: Mack Date: Fri, 7 Jun 2024 15:33:04 +0800 Subject: [PATCH 7/9] ci: using the flatpak patch JIRA: STUDIO-6329 Change-Id: I6625659017ca84113a3bba8656abea87cc0bebd8 --- deps/CGAL/CGAL.cmake | 2 +- deps/CMakeLists.txt | 68 ++++++++++++++++++++++++++-------- deps/CURL/CURL.cmake | 4 +- deps/Cereal/Cereal.cmake | 8 ++-- deps/OCCT/OCCT.cmake | 5 ++- deps/OpenVDB/OpenVDB.cmake | 2 +- deps/TIFF/TIFF.cmake | 2 +- deps/wxWidgets/wxWidgets.cmake | 17 ++++----- src/libslic3r/Format/svg.cpp | 10 ++--- 9 files changed, 81 insertions(+), 37 deletions(-) diff --git a/deps/CGAL/CGAL.cmake b/deps/CGAL/CGAL.cmake index 987f8260ee..94ba84d9cd 100644 --- a/deps/CGAL/CGAL.cmake +++ b/deps/CGAL/CGAL.cmake @@ -5,7 +5,7 @@ bambustudio_add_cmake_project( # For whatever reason, this keeps downloading forever (repeats downloads if finished) URL https://github.com/CGAL/cgal/archive/refs/tags/v5.4.zip URL_HASH SHA256=d7605e0a5a5ca17da7547592f6f6e4a59430a0bc861948974254d0de43eab4c0 - DEPENDS dep_Boost dep_GMP dep_MPFR + DEPENDS ${BOOST_PKG} dep_GMP dep_MPFR ) include(GNUInstallDirs) diff --git a/deps/CMakeLists.txt b/deps/CMakeLists.txt index 0b44d5c107..09f70b7fce 100644 --- a/deps/CMakeLists.txt +++ b/deps/CMakeLists.txt @@ -31,6 +31,15 @@ if (NPROC EQUAL 0) set(NPROC 1) endif () +option(DEP_BUILD_PNG "Compile libpng" ON) +option(DEP_BUILD_JPEG "Compile libjpeg" ON) +option(DEP_BUILD_TIFF "Compile libtiff" ON) +option(DEP_BUILD_BOOST "Compile boost" ON) +option(DEP_BUILD_OPENSSL "Compile openssl" ON) +option(DEP_BUILD_GLFW "Compile GLFW" ON) +option(DEP_BUILD_FREETYPE "Compile freetype" ON) +option(DEP_BUILD_WXWIDGETS "Compile wxWidgets" ON) + set(DESTDIR "${CMAKE_CURRENT_BINARY_DIR}/destdir" CACHE PATH "Destination directory") set(DEP_DOWNLOAD_DIR ${CMAKE_CURRENT_BINARY_DIR} CACHE PATH "Path for downloaded source packages.") @@ -148,10 +157,20 @@ if (NOT ZLIB_FOUND) set(ZLIB_PKG dep_ZLIB) endif () set(PNG_PKG "") -if (NOT PNG_FOUND) +if (DEP_BUILD_PNG AND NOT PNG_FOUND) include(PNG/PNG.cmake) set(PNG_PKG dep_PNG) endif () +set(JPEG_PKG "") +if (DEP_BUILD_JPEG AND NOT JPEG_FOUND) + include(JPEG/JPEG.cmake) + set(JPEG_PKG dep_JPEG) +endif() +set(TIFF_PKG "") +if (DEP_BUILD_TIFF AND NOT TIFF_FOUND) + include(TIFF/TIFF.cmake) + set(TIFF_PKG dep_TIFF) +endif() set(EXPAT_PKG "") if (NOT EXPAT_FOUND) include(EXPAT/EXPAT.cmake) @@ -159,13 +178,21 @@ if (NOT EXPAT_FOUND) endif () set(DEP_Boost_COMPONENTS system iostreams filesystem thread log locale regex date_time) -include(Boost/Boost.cmake) +set(BOOST_PKG "") +if (DEP_BUILD_BOOST) + include(Boost/Boost.cmake) + set(BOOST_PKG dep_Boost) +endif () # The order of includes respects the dependencies between libraries include(Cereal/Cereal.cmake) include(Qhull/Qhull.cmake) include(GLEW/GLEW.cmake) -include(GLFW/GLFW.cmake) +set(GLFW_PKG "") +if (DEP_BUILD_GLFW) + include(GLFW/GLFW.cmake) + set(GLFW_PKG dep_GLFW) +endif () include(OpenCSG/OpenCSG.cmake) include(TBB/TBB.cmake) @@ -180,37 +207,46 @@ include(CGAL/CGAL.cmake) include(NLopt/NLopt.cmake) -include(OpenSSL/OpenSSL.cmake) - +set(OPENSSL_PKG "") +if (DEP_BUILD_OPENSSL) + include(OpenSSL/OpenSSL.cmake) + set(OPENSSL_PKG dep_OpenSSL) +endif () set(CURL_PKG "") if (NOT CURL_FOUND) include(CURL/CURL.cmake) set(CURL_PKG dep_CURL) endif () - -include(JPEG/JPEG.cmake) -include(TIFF/TIFF.cmake) -include(wxWidgets/wxWidgets.cmake) +set(WXWIDGETS_PKG "") +if (DEP_BUILD_WXWIDGETS) + include(wxWidgets/wxWidgets.cmake) + set(WXWIDGETS_PKG dep_wxWidgets) +endif () +set(FREETYPE_PKG "") +if (DEP_BUILD_FREETYPE) + include(FREETYPE/FREETYPE.cmake) + set(FREETYPE_PKG dep_FREETYPE) +endif () include(OCCT/OCCT.cmake) include(OpenCV/OpenCV.cmake) -include(FREETYPE/FREETYPE.cmake) set(_dep_list - dep_Boost + ${BOOST_PKG} dep_TBB ${CURL_PKG} - dep_wxWidgets + ${WXWIDGETS_PKG} dep_Cereal dep_NLopt dep_OpenVDB dep_OpenCSG dep_OpenCV dep_CGAL - dep_OpenSSL - dep_GLFW + ${OPENSSL_PKG} + ${GLFW_PKG} ${PNG_PKG} ${ZLIB_PKG} ${EXPAT_PKG} + ${FREETYPE_PKG} ) if (MSVC) @@ -223,7 +259,9 @@ else() endif() list(APPEND _dep_list "dep_OCCT") -list(APPEND _dep_list "dep_FREETYPE") +# if (DEP_BUILD_FREETYPE) +# list(APPEND _dep_list "dep_FREETYPE") +# endif () add_custom_target(deps ALL DEPENDS ${_dep_list}) diff --git a/deps/CURL/CURL.cmake b/deps/CURL/CURL.cmake index b3c83b768d..546e2f703d 100644 --- a/deps/CURL/CURL.cmake +++ b/deps/CURL/CURL.cmake @@ -72,7 +72,9 @@ bambustudio_add_cmake_project(CURL ${_curl_platform_flags} ) -add_dependencies(dep_CURL dep_OpenSSL) +if (DEP_BUILD_OPENSSL AND CMAKE_SYSTEM_NAME STREQUAL "Linux") + add_dependencies(dep_CURL ${OPENSSL_PKG}) +endif () if (MSVC) add_debug_dep(dep_CURL) diff --git a/deps/Cereal/Cereal.cmake b/deps/Cereal/Cereal.cmake index 4651bab85d..1bd9e3f829 100644 --- a/deps/Cereal/Cereal.cmake +++ b/deps/Cereal/Cereal.cmake @@ -1,6 +1,8 @@ bambustudio_add_cmake_project(Cereal - URL "https://github.com/USCiLab/cereal/archive/v1.2.2.tar.gz" - URL_HASH SHA256=1921f26d2e1daf9132da3c432e2fd02093ecaedf846e65d7679ddf868c7289c4 + URL "https://github.com/USCiLab/cereal/archive/refs/tags/v1.3.0.zip" + URL_HASH SHA256=71642cb54658e98c8f07a0f0d08bf9766f1c3771496936f6014169d3726d9657 CMAKE_ARGS - -DJUST_INSTALL_CEREAL=on + -DJUST_INSTALL_CEREAL=ON + -DSKIP_PERFORMANCE_COMPARISON=ON + -DBUILD_TESTS=OFF ) \ No newline at end of file diff --git a/deps/OCCT/OCCT.cmake b/deps/OCCT/OCCT.cmake index 2943a3cbbd..4d7aa7e9a0 100644 --- a/deps/OCCT/OCCT.cmake +++ b/deps/OCCT/OCCT.cmake @@ -18,6 +18,7 @@ bambustudio_add_cmake_project(OCCT #-DUSE_FREETYPE=OFF -DUSE_FFMPEG=OFF -DUSE_VTK=OFF + -DBUILD_DOC_Overview=OFF -DBUILD_MODULE_ApplicationFramework=OFF #-DBUILD_MODULE_DataExchange=OFF -DBUILD_MODULE_Draw=OFF @@ -27,4 +28,6 @@ bambustudio_add_cmake_project(OCCT -DBUILD_MODULE_Visualization=OFF ) -add_dependencies(dep_OCCT dep_FREETYPE) +if (DEP_BUILD_FREETYPE) + add_dependencies(dep_OCCT ${FREETYPE_PKG}) +endif () \ No newline at end of file diff --git a/deps/OpenVDB/OpenVDB.cmake b/deps/OpenVDB/OpenVDB.cmake index e22568cfd7..7a28341d50 100644 --- a/deps/OpenVDB/OpenVDB.cmake +++ b/deps/OpenVDB/OpenVDB.cmake @@ -17,7 +17,7 @@ bambustudio_add_cmake_project(OpenVDB URL_HASH SHA256=f353e7b99bd0cbfc27ac9082de51acf32a8bc0b3e21ff9661ecca6f205ec1d81 # URL https://github.com/AcademySoftwareFoundation/openvdb/archive/refs/tags/v10.0.1.zip # URL_HASH SHA256=48C2CFA9853B58FA86282DF1F83F0E99D07858CC03EB2BA8227DC447A830100A - DEPENDS dep_TBB dep_Blosc dep_OpenEXR dep_Boost + DEPENDS dep_TBB dep_Blosc dep_OpenEXR ${BOOST_PKG} CMAKE_ARGS -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DOPENVDB_BUILD_PYTHON_MODULE=OFF diff --git a/deps/TIFF/TIFF.cmake b/deps/TIFF/TIFF.cmake index f820b6a755..93b3fcfc57 100644 --- a/deps/TIFF/TIFF.cmake +++ b/deps/TIFF/TIFF.cmake @@ -3,7 +3,7 @@ find_package(OpenGL QUIET REQUIRED) bambustudio_add_cmake_project(TIFF URL https://gitlab.com/libtiff/libtiff/-/archive/v4.1.0/libtiff-v4.1.0.zip URL_HASH SHA256=c56edfacef0a60c0de3e6489194fcb2f24c03dbb550a8a7de5938642d045bd32 - DEPENDS ${ZLIB_PKG} ${PNG_PKG} dep_JPEG + DEPENDS ${ZLIB_PKG} ${PNG_PKG} ${JPEG_PKG} CMAKE_ARGS -Dlzma:BOOL=OFF -Dwebp:BOOL=OFF diff --git a/deps/wxWidgets/wxWidgets.cmake b/deps/wxWidgets/wxWidgets.cmake index 5aebbceea3..b7af0750ca 100644 --- a/deps/wxWidgets/wxWidgets.cmake +++ b/deps/wxWidgets/wxWidgets.cmake @@ -1,4 +1,4 @@ -set(_wx_git_tag v3.1.5) +set(_wx_git_tag bambu) set(_wx_toolkit "") if(CMAKE_SYSTEM_NAME STREQUAL "Linux") @@ -18,17 +18,16 @@ else () set(_wx_edge "-DwxUSE_WEBVIEW_EDGE=OFF") endif () -if (MSVC) - set(_patch_cmd ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch) -else () - set(_patch_cmd test -f WXWIDGETS_PATCHED || ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch && touch WXWIDGETS_PATCHED) -endif () +# if (MSVC) +# set(_patch_cmd ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch) +# else () +# set(_patch_cmd test -f WXWIDGETS_PATCHED || ${PATCH_CMD} ${CMAKE_CURRENT_LIST_DIR}/0001-wxWidget-fix.patch && touch WXWIDGETS_PATCHED) +# endif () bambustudio_add_cmake_project(wxWidgets - GIT_REPOSITORY "https://github.com/wxWidgets/wxWidgets" + GIT_REPOSITORY "https://github.com/MackBambu/wxWidgets" GIT_TAG ${_wx_git_tag} - PATCH_COMMAND ${_patch_cmd} - DEPENDS ${PNG_PKG} ${ZLIB_PKG} ${EXPAT_PKG} dep_TIFF dep_JPEG + DEPENDS ${PNG_PKG} ${ZLIB_PKG} ${EXPAT_PKG} ${TIFF_PKG} ${JPEG_PKG} CMAKE_ARGS -DwxBUILD_PRECOMP=ON ${_wx_toolkit} diff --git a/src/libslic3r/Format/svg.cpp b/src/libslic3r/Format/svg.cpp index 4a96274b99..7bfd73b987 100644 --- a/src/libslic3r/Format/svg.cpp +++ b/src/libslic3r/Format/svg.cpp @@ -1,3 +1,4 @@ +#include "libslic3r/ClipperUtils.hpp" #include "../libslic3r.h" #include "../Model.hpp" #include "../TriangleMesh.hpp" @@ -19,9 +20,8 @@ #include "TopExp_Explorer.hxx" #include "TopoDS.hxx" #include "BRepExtrema_SelfIntersection.hxx" -#include "clipper/clipper.hpp" - -using namespace ClipperLib; +#include "libslic3r/clipper.hpp" +#include "libslic3r/Polygon.hpp" namespace Slic3r { const double STEP_TRANS_CHORD_ERROR = 0.005; @@ -213,9 +213,9 @@ bool get_svg_profile(const char *path, std::vector &element_infos, for (int i = 0; i < path_line_points.size(); ++i) { ClipperLib::Path pt_path; for (auto line_point : path_line_points[i]) { - pt_path.push_back(IntPoint(line_point.first.X() * scale_size, line_point.first.Y() * scale_size)); + pt_path.push_back(ClipperLib::IntPoint(line_point.first.X() * scale_size, line_point.first.Y() * scale_size)); } - pt_path.push_back(IntPoint(path_line_points[i].back().second.X() * scale_size, path_line_points[i].back().second.Y() * scale_size)); + pt_path.push_back(ClipperLib::IntPoint(path_line_points[i].back().second.X() * scale_size, path_line_points[i].back().second.Y() * scale_size)); ClipperLib::Paths out_paths; ClipperLib::ClipperOffset co; From a181250668fae3110e329c0dd289f1e71dd1bb45 Mon Sep 17 00:00:00 2001 From: Mack Date: Tue, 18 Jun 2024 11:48:39 +0800 Subject: [PATCH 8/9] ci: change wxWidgets source to official repository JIRA: STUDIO-6329 Change-Id: I31e0c891b24b4ba89993fcd7c3d1a5c67d2d117f --- deps/wxWidgets/wxWidgets.cmake | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/deps/wxWidgets/wxWidgets.cmake b/deps/wxWidgets/wxWidgets.cmake index b7af0750ca..e9982a6fba 100644 --- a/deps/wxWidgets/wxWidgets.cmake +++ b/deps/wxWidgets/wxWidgets.cmake @@ -1,5 +1,3 @@ -set(_wx_git_tag bambu) - set(_wx_toolkit "") if(CMAKE_SYSTEM_NAME STREQUAL "Linux") set(_gtk_ver 2) @@ -25,8 +23,8 @@ endif () # endif () bambustudio_add_cmake_project(wxWidgets - GIT_REPOSITORY "https://github.com/MackBambu/wxWidgets" - GIT_TAG ${_wx_git_tag} + GIT_REPOSITORY "https://github.com/bambulab/wxWidgets" + GIT_TAG master DEPENDS ${PNG_PKG} ${ZLIB_PKG} ${EXPAT_PKG} ${TIFF_PKG} ${JPEG_PKG} CMAKE_ARGS -DwxBUILD_PRECOMP=ON From a078ccefc49d6d3aac925c097d63abb03c13271b Mon Sep 17 00:00:00 2001 From: Mack Date: Tue, 18 Jun 2024 12:08:10 +0800 Subject: [PATCH 9/9] ENH: add depend logic of curl to openssl for all platform JIRA: STUDIO-6329 Change-Id: Id0251b4862c6b718e885437c036511358be04748 --- deps/CURL/CURL.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/CURL/CURL.cmake b/deps/CURL/CURL.cmake index 546e2f703d..6de704ff8f 100644 --- a/deps/CURL/CURL.cmake +++ b/deps/CURL/CURL.cmake @@ -72,7 +72,7 @@ bambustudio_add_cmake_project(CURL ${_curl_platform_flags} ) -if (DEP_BUILD_OPENSSL AND CMAKE_SYSTEM_NAME STREQUAL "Linux") +if (DEP_BUILD_OPENSSL) add_dependencies(dep_CURL ${OPENSSL_PKG}) endif ()