Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration parameter to indicate spring boot track #314

Closed
gabheadz opened this issue Feb 2, 2023 · 3 comments
Closed

Add configuration parameter to indicate spring boot track #314

gabheadz opened this issue Feb 2, 2023 · 3 comments
Milestone

Comments

@gabheadz
Copy link
Contributor

gabheadz commented Feb 2, 2023

Is your feature request related to a problem? Please describe.
Define a configuration flag to indicate to the ca task which track of spring-boot to use.

Describe the solution you'd like
If and only if we decide to provide this level of configuration, then I would imagine a parameter like this:

gradlew ca --package=com.example.demo --type=reactive --name=demo --coverage=jacoco --lombok=true --bootVersion=VERSION_2

or

gradlew ca --package=com.example.demo --type=reactive --name=demo --coverage=jacoco --lombok=true  --bootVersion=VERSION_3

if bootVersion=VERSION_3 is selected, then javaVersion should be automatically defined as JAVA_17

Describe alternatives you've considered

One alternative is to keep the scaffolder versions up to 2.x.x using spring-boot 2.7.x and produce a new major version of the scaffolder 3.x fixed for spring boot 3.x.

@gabheadz gabheadz added this to the Spring Boot 3 milestone Feb 2, 2023
@juancgalvis
Copy link
Contributor

Hi @gabheadz, I think that we should only support the latest release of Spring Boot, what do you think @dbuos @santitigaga @maocq?

@santitigaga
Copy link
Contributor

I think the same.
If consumer use the plugin version 3.x we could generate the project with spring boot 3. or if you use the plugin version 2.x we could generate the project with spring boot 2.

We might need to change something in the previous version (2.x). we can do this with a branch to update this version.

@juancgalvis
Copy link
Contributor

It will not be implemented

@juancgalvis juancgalvis closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants