Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entry point): add versioning property to generate entrypoint #582

Merged
merged 6 commits into from
Nov 18, 2024
Merged

feat(entry point): add versioning property to generate entrypoint #582

merged 6 commits into from
Nov 18, 2024

Conversation

santitigaga
Copy link
Contributor

@santitigaga santitigaga commented Nov 18, 2024 •
edited
Loading

Before submitting a pull request, please read
https://bancolombia.github.io/scaffold-clean-architecture/docs/contributing

Description

Category

  • Feature
  • Fix
  • Ci / Docs

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • If the pull request has a new driven-adapter or entry-point, you should add it to docs and sh_generate_project.sh files for generated code tests.
  • If the pull request has changed structural files, you have implemented an UpgradeAction according to the guide
  • If the pull request has a new Gradle Task, you should add Analytics according to the guide

juancgalvis
juancgalvis requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@juancgalvis juancgalvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the generated project compile and pass the generated unit tests

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@santitigaga santitigaga merged commit 3c21077 into master Nov 18, 2024
8 checks passed
@santitigaga santitigaga deleted the feature/version-strategy-api branch November 18, 2024 16:36
@app-toolkit-opensource-innersource APP Toolkit OpenSource - InnerSource
Copy link
Contributor

🎉 This PR is included in version 3.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancgalvis juancgalvis juancgalvis approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santitigaga @juancgalvis