Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kustomize deployment #188

Open
ramizpolic opened this issue Sep 6, 2023 · 3 comments
Open

Add support for kustomize deployment #188

ramizpolic opened this issue Sep 6, 2023 · 3 comments
Labels
lifecycle/keep Denotes an issue or PR that should be preserved from going stale.

Comments

@ramizpolic
Copy link
Member

ramizpolic commented Sep 6, 2023

Goal

We would like to provide a way to deploy operator using kustomize leveraging kubebuilder. This requires adding the deployment and updating necessary RBAC policies.

Use https://github.com/bank-vaults/vault-operator/tree/main/deploy/charts/vault-operator as a reference.

Ensure that documentation guide works for Vault CRs added to a default, as well as custom namespace.

@cjyar
Copy link

cjyar commented Sep 13, 2023

As an alternative, users could use kustomize's helmCharts support. However, kustomize doesn't support helm charts with the oci:// scheme (kubernetes-sigs/kustomize#4381). If bank-vaults offered an https helm registry, that would work.

@ramizpolic
Copy link
Member Author

That does pass all the heavy lifting away from us, which is awesome @cjyar. Referenced PR kubernetes-sigs/kustomize#5167 seems to be ready for merge, so we can probably expect the release sometime soon.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Dec 3, 2023
@cjyar
Copy link

cjyar commented Dec 3, 2023

Kustomize now supports helmCharts with an oci:// scheme. That support has been taken up by argo-cd, which meets all of my needs. It's possible that that's enough for the other users of bank-vaults also.

@ramizpolic ramizpolic removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Dec 4, 2023
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Feb 4, 2024
@ramizpolic ramizpolic removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Feb 5, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Apr 7, 2024
@ramizpolic ramizpolic removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Apr 7, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jun 9, 2024
@csatib02 csatib02 added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jun 9, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 9, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 9, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 9, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
Status: 🔖 Ready for work
Development

No branches or pull requests

3 participants