Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general error handling (no answer from backend, failed to parse answer from backend) #190

Open
KirDE opened this issue May 25, 2021 · 3 comments

Comments

@KirDE
Copy link
Contributor

KirDE commented May 25, 2021

In the client, we should just have a general exception handler that shows an error message. (For alle pages in App.tsx) (React Error Boundary component) (@NineBerry )

@NineBerry
Copy link
Contributor

Need a design how an error page should look like

@KirDE
Copy link
Contributor Author

KirDE commented May 30, 2021

for now just use error styles for new banner

@fauri13
Copy link
Member

fauri13 commented May 30, 2021

One thing is the ErrorBoundary component, that catches unhandled errors in the code and another thing is to handle api errors.
Right now, errors from API are already catched and do not throw a fatal error. I suggest leaving it as is for now as I don't thinks is an issue right now. Haven't heard any complains about it and it's difficult to test. I'm not saying we should do nothing but maybe move to a future version as it can take some time to do it right.

@KirDE KirDE modified the milestones: v1.2, v.2.0 May 31, 2021
@ewoerner ewoerner removed this from the v.2.0 milestone Jul 24, 2021
@NineBerry NineBerry assigned NineBerry and unassigned NineBerry Feb 10, 2023
@KirDE KirDE changed the title general error handling (no answer from backend, failed to parce answer from backend) general error handling (no answer from backend, failed to parse answer from backend) Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants