You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello :)
I have also an issue with rule-statefulset when I upgrade Thanos chart with the rule object enable, even without rulefiles.
Error: UPGRADE FAILED: YAML parse error on thanos/templates/rule-statefulset.yaml: error converting YAML to JSON: yaml: line 44: did not find expected key
I Don't kwow if t's related or if someone have encounter similar issue
Describe the bug
when the rule component is enabled, the volume from configmap of thanos-rules is not rendered correctly in the rule-statefulset template. Check out this line:
https://github.com/banzaicloud/banzai-charts/blob/master/thanos/templates/rule-statefulset.yaml#L132
{{- if empty .Values.rule.ruleOverrideName -}}
The right-hand trimming-off should be removed, so it looks like this:
Steps to reproduce the issue:
$ helm template thanos -n monitoring -x templates/rule-statefulset.yaml --set rule.enabled=true
Check the last two lines for rule-volume in the output:
Expected behavior
The rule-volume from configmap should be rendered as below:
Screenshots
Additional context
The workaround is to specify the
.Values.rule.ruleOverrideName
value, however, with this.rule.ruleOverrideName
value set, the configmap for the thanos-rules is not turned on, due to the condition for the configmap requiring theruleOverrideName
be empty: https://github.com/banzaicloud/banzai-charts/blob/master/thanos/templates/rule-configmap.yaml#L1The text was updated successfully, but these errors were encountered: