Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git branch and commit empty in Docker after updating from 0.29.0 #173

Closed
Esgrove opened this issue Aug 13, 2024 · 2 comments · Fixed by #174
Closed

Git branch and commit empty in Docker after updating from 0.29.0 #173

Esgrove opened this issue Aug 13, 2024 · 2 comments · Fixed by #174

Comments

@Esgrove
Copy link

Esgrove commented Aug 13, 2024

I have an API that runs in Docker.

In my dockerfile, I copy the .git dir to the docker builder image so shadow can read the values.

COPY api/Cargo.toml api/Cargo.lock api/build.rs api/.cargo/config.toml .git ./

However, after updating to 0.31.0 and 0.31.1, the git variables that I use are empty so shadow-rs no longer works correctly when building inside Docker.

@Esgrove
Copy link
Author

Esgrove commented Aug 13, 2024

Turns out the amazon linux docker image does not have git available by default. Works after installing git in the image first.

Would be good for you to document that this crate now requires git to be available unlike previously. The CHANGELOG.md document has not been updated in two years as well so please either start updating it again or just remove it since currently it is not providing any value.

@baoyachi
Copy link
Owner

@Esgrove Please use new publised version:

shadow-rs = "0.32.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants