Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Adapt manual deployment scripts #238

Merged
merged 3 commits into from
Jan 14, 2023
Merged

👷 Adapt manual deployment scripts #238

merged 3 commits into from
Jan 14, 2023

Conversation

baptisteArno
Copy link
Owner

Closes #235

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
builder-v2 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 14, 2023 at 0:12AM (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 14, 2023 at 0:12AM (UTC)
landing-page-v2 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 14, 2023 at 0:12AM (UTC)
viewer-v2 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 14, 2023 at 0:12AM (UTC)

@itzomen
Copy link
Contributor

itzomen commented Jan 12, 2023

@baptisteArno I think the apps/viewer build command would need a similar update as the apps/builder build command

@baptisteArno
Copy link
Owner Author

Indeed! Can you do it and let me know if it all works?

@itzomen
Copy link
Contributor

itzomen commented Jan 12, 2023

Indeed! Can you do it and let me know if it all works?

Sure, getting to it asap

@@ -4,7 +4,7 @@
"license": "AGPL-3.0-or-later",
"scripts": {
"dev": "cross-env ENVSH_ENV=.env.local sh ../../env.sh next dev -p 3000",
"build": "next build",
"build": "cross-env ENVSH_ENV=.env.local sh ../../env.sh next build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baptisteArno this loads the env in the manual deployment but I tweak the command i.e change sh to bash

"build": "cross-env ENVSH_ENV=.env.local bash ../../env.sh next build"

Additionally, I added to it to apps/viewer build command

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why sh wouldn't work? What's your OS / distrib?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux / Ubuntu 22

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error do you have when running the script with sh?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the output:

-e env.sh loaded
../../env.sh: 75: [[: not found
../../env.sh: 102: Syntax error: redirection unexpected

@baptisteArno
Copy link
Owner Author

baptisteArno commented Jan 14, 2023

Looking forward to your simple documentation on how to deploy the apps manually @itzomen 🙏

@itzomen
Copy link
Contributor

itzomen commented Jan 14, 2023

Looking forward to your simple documentation on how to deploy the apps manually @itzomen 🙏

Alright, sounds good

Expect it by Monday 🙂

@baptisteArno
Copy link
Owner Author

Alright, sounds good

Expect it by Monday 🙂

You rock! Thanks 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected token 'I', "Internal S"... is not valid JSON
2 participants