-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Adapt manual deployment scripts #238
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@baptisteArno I think the apps/viewer build command would need a similar update as the apps/builder build command |
Indeed! Can you do it and let me know if it all works? |
Sure, getting to it asap |
apps/builder/package.json
Outdated
@@ -4,7 +4,7 @@ | |||
"license": "AGPL-3.0-or-later", | |||
"scripts": { | |||
"dev": "cross-env ENVSH_ENV=.env.local sh ../../env.sh next dev -p 3000", | |||
"build": "next build", | |||
"build": "cross-env ENVSH_ENV=.env.local sh ../../env.sh next build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baptisteArno this loads the env in the manual deployment but I tweak the command i.e change sh
to bash
"build": "cross-env ENVSH_ENV=.env.local bash ../../env.sh next build"
Additionally, I added to it to apps/viewer build command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why sh
wouldn't work? What's your OS / distrib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux / Ubuntu 22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What error do you have when running the script with sh
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the output:
-e env.sh loaded
../../env.sh: 75: [[: not found
../../env.sh: 102: Syntax error: redirection unexpected
4c214c8
to
c1cf1d2
Compare
Looking forward to your simple documentation on how to deploy the apps manually @itzomen 🙏 |
Alright, sounds good Expect it by Monday 🙂 |
You rock! Thanks 💙 |
Closes #235