Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooling and other features don't work on arduino #2

Open
urh opened this issue Mar 4, 2016 · 4 comments
Open

Cooling and other features don't work on arduino #2

urh opened this issue Mar 4, 2016 · 4 comments
Assignees
Labels

Comments

@urh
Copy link

urh commented Mar 4, 2016

Changed SendElectra and EncodeElectra have int in their params, but in the code their params are shifter up to 32 bits, even though they are 16 bits in arduino. Causes only the cooling and on/off options to work.

They should be uint32_t

@barakwei
Copy link
Owner

barakwei commented Mar 4, 2016

I prefer to create bitfield struct of the protocol which will make everything clearer and simpler

@barakwei barakwei self-assigned this Mar 4, 2016
@urh
Copy link
Author

urh commented Mar 4, 2016

Cool :) 👍

@barakwei
Copy link
Owner

barakwei commented Mar 4, 2016

Interesting to see that in particle development environment which should be very similar to arduino, int has 4 bytes.

@barakwei barakwei changed the title Changed SendElectra and EncodeElectra to uint32_t Cooling and other features don't work on arduino Mar 4, 2016
@barakwei barakwei added the bug label Jul 26, 2016
@barakwei
Copy link
Owner

I rewrote the library, and it's live on version-2.0 branch. Check it out, the issue should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants