Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a console error occurring due to line break in string literal #1

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Conversation

tjdraper
Copy link
Contributor

@tjdraper tjdraper commented Feb 22, 2019

The line break in the string literal on the jQuery .append causes a JavaScript error that causes many problems in the Craft control panel. This PR removes the line break which fixes the issue.

Screenshot of old code with line break:

screenshot_2

Screenshots of error occurring (note a completely unrelated field called content, which is a redactor field, is not rendering because of this JS error):

screenshot_4

screenshot_5

@tjdraper
Copy link
Contributor Author

I've currently updated the project where this became a problem to pull from my forked repositories, but I'd love to get back on official composer/packagist releases as soon as possible.

@BenParizek BenParizek merged commit 0050267 into barrelstrength:develop Feb 26, 2019
@BenParizek
Copy link
Member

@tjdraper I overlooked updating you here but this was resolved in an earlier release (v3.2.4) and should be fixed if you update to the latest stable release (v3.2.8).

@tjdraper
Copy link
Contributor Author

Yep, all good. Thanks!

@kerrig
Copy link

kerrig commented Jun 10, 2019

@BenParizek Looks like this issue was reintroduced in the last round of commits: 169d2ca#diff-a3e08b7b070ebb7604a5bc16fbd0dcb4

I'm having this issue on version 3.4

@BenParizek
Copy link
Member

Thanks @kerrig. It looks like the issue here had to do with our my code editor cleaned up and reformatted the Twig code. I've adjusted the settings to avoid accidentally reintroducing this scenario again. Fixed in v3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants