Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template's style blocks should overload base template super #7

Closed
thorin-schiffer opened this issue Apr 4, 2017 · 2 comments
Closed
Assignees

Comments

@thorin-schiffer
Copy link

In the case, when the base_site.html template is overloaded and uses extra styles, timeline won't see it, because extrastyle and extrahead blocks overload the parent's ones without calling {{ block.super}}

Should become something like:

{% block extrastyle %}
    {{ block.super }}
    <link rel="stylesheet" type="text/css" href="{% static 'admin_timeline/css/admin_timeline.css' %}"/>
    <link rel="stylesheet" type="text/css"
          href="{% static 'admin_timeline/libs/multiple-select/multiple-select.css' %}"/>
{% endblock extrastyle %}
{% block extrahead %}
    {{ block.super }}
    <script type="text/javascript" src="{% url 'admin:jsi18n' %}"></script>
    <script src="{% static 'admin/js/core.js' %}"></script>
    <script src="{% static 'admin_timeline/libs/jquery-1.11.2.min.js' %}"></script>
    <script src="{% static 'admin_timeline/libs/multiple-select/jquery.multiple.select.js' %}"></script>
    <script src="{% static 'admin_timeline/js/admin_timeline.js' %}"></script>
{% endblock extrahead %}
{% block coltype %}colMS{% endblock %}
@barseghyanartur
Copy link
Owner

@eviltnan:

Thanks for bringing this up. I'll check it soon.

@barseghyanartur
Copy link
Owner

@eviltnan:

Fixed in version 1.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants