Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On 1.2.6, setting $notification-default-position does not work #89

Closed
mattheworres opened this issue Dec 21, 2016 · 2 comments
Closed

Comments

@mattheworres
Copy link

Given that I set the SASS variable $notification-default-position from something different from the default of top right (to middle bottom, for example) any and all notifications without a position attribute specified still show up in the top right.

@soumak77 soumak77 added the bug label Dec 28, 2016
@soumak77
Copy link
Contributor

The issue is caused by the code using the class top-right when no position is provided:

This should be changed to use a default-position class instead so the default position is taken from the SASS variable. The following styling should be added under .static-notification and .notification-container in https://github.com/base-apps/angular-base-apps/blob/master/scss/components/_notification.scss.

&.default-position     { @include notification-layout(); }

@soumak77
Copy link
Contributor

fixed by d30e8b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants