From 3c01dc75fdb622adf0763b7f00ad79a9d8bec43a Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Mon, 20 Jan 2025 18:53:48 -0500 Subject: [PATCH] ci: use `fail-fast: false` instead of `continue-on-error: true` This will give us proper red/green signal on the test suite while still running the entire matrix. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dcd1b0ec..8da7d39c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,6 +23,7 @@ jobs: run: bundle exec rubocop --parallel tests: strategy: + fail-fast: false matrix: ruby-version: - "3.1" @@ -37,7 +38,6 @@ jobs: gemfile: gemfiles/rails_edge.gemfile name: ${{ format('Tests (Ruby {0})', matrix.ruby-version) }} runs-on: ubuntu-latest - continue-on-error: true env: BUNDLE_GEMFILE: ${{ github.workspace }}/${{ matrix.gemfile }} steps: