Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken with OTP 21: use of the deprecated get_stacktrace/0 in dependency meck #260

Open
yati-sagade opened this issue Apr 15, 2019 · 3 comments

Comments

@yati-sagade
Copy link

get_stacktrace/0 has been removed since OTP 21. The upstream meck project (https://github.com/eproxus/meck) has addressed this, can you please update your fork if possible?

This is the error I see when I try to build:

$ make
...
==> meck (compile)
Compiled src/meck_history.erl
Compiled src/meck_proc.erl
/home/ysagade/bitcask/deps/meck/src/meck_code_gen.erl:182: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
ERROR: compile failed while processing /home/ysagade/bitcask/deps/meck: rebar_abort
make: *** [Makefile:16: compile] Error 1

Do I need to downgrade? Or can m

@yati-sagade
Copy link
Author

I guess that alone isn't enough. Are there plans to migrate to R21?

@martincox
Copy link
Contributor

Work has already been done for OTP21, @Vagabond created #259. Sounds like there are some issues still to be worked out though. As far as I know, no one is looking into them right now, though.

@evanmcc
Copy link
Contributor

evanmcc commented Apr 17, 2019

I checked out #259 and ran the eqc tests (I've changed jobs since my original comment) and will do some more on an overnight run. Tomorrow, I'll see if I can get the pulse test running. given the limited scope of the PR, I wouldn't expect too much trouble, though. I'm not sure what the current org would want as verification before merging, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants