Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail.hpp atomic functions called with unsigend types [JIRA: RIAK-2237] #166

Open
erikleitch opened this issue Oct 23, 2015 · 0 comments
Open
Assignees

Comments

@erikleitch
Copy link

detail.hpp was added with the prototype range scan code. This collects together atomic add/inc/dec functions for different platforms. However, calls to atomic_add_32/64, which expect signed delta arguments, are prototyped with unsigned arguments.

This raises the issue of whether a) these functions could ever get called with unsigned values that could overflow the corresponding signed types, and b) whether the higher-level code that calls these functions can overflow their memory buffers, both of which should be checked

@erikleitch erikleitch self-assigned this Oct 23, 2015
@Basho-JIRA Basho-JIRA changed the title detail.hpp atomic functions called with unsigend types detail.hpp atomic functions called with unsigend types [JIRA: RIAK-2237] Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants