Had an issue when trying to read the Riak server's version number #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number string 1.4.2-0-g61ac9d8
|
Is the server version coming back from http://localhost:10018/stats (or the corresponding URL on your Riak server?) |
|
I am using the IP address for the AWS server to connect and retrieve the version number. |
| @@ -27,7 +27,7 @@ def get_server_version | |||
| # @return [Gem::Version] the version of the Riak node to which | |||
| # this backend is connected | |||
| def server_version | |||
| @server_version ||= Gem::Version.new(get_server_version) | |||
| @server_version ||= Gem::Version.new(get_server_version[0,5]) | |||
There was a problem hiding this comment.
This should truncate after the first minus, to support cases when Riak has two digits in some components of the version number.
There was a problem hiding this comment.
So it should look something like:
get_server_version = get_server_version.split("-").first
@server_version ||= Gem::Version.new(get_server_version)
|
Made the change to use .split("-").first instead of straight truncating at the 5th index. |
bkerley
added a commit
that referenced
this pull request
Sep 5, 2013
Had an issue when trying to read the Riak server's version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trimming the version number to prevent Rails error: Malformed version number string 1.4.2-0-g61ac9d8
This was the version number sent back from the Riak Server that is currently hosted on AWS. I'm not entirely sure why it is read that way on my end, but when I SSH into that AWS server and check Riak's version it just says 1.4.2.
This was a simple fix that I did, if there is a better way to do this, I am all ears.
Thanks,
Jace