Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys and vals support for sequences of map entries #1018

Closed
chrisrink10 opened this issue Aug 29, 2024 · 0 comments · Fixed by #1017
Closed

keys and vals support for sequences of map entries #1018

chrisrink10 opened this issue Aug 29, 2024 · 0 comments · Fixed by #1017
Labels
issue-type:bug Something isn't working lang Issue pertaining to Basilisp language modules

Comments

@chrisrink10
Copy link
Member

In #1011, the issue was raised that several core functions don't properly support nil values as they do in Clojure. Among those were keys and vals.

Upon further exploration, those functions support more than just mapping types and nil, but in fact any sequence yielding successive map entries (so calling (keys (seq {:a 1 ...})) will yield the keys of the sequence of the source map as well.

@chrisrink10 chrisrink10 added issue-type:bug Something isn't working lang Issue pertaining to Basilisp language modules labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-type:bug Something isn't working lang Issue pertaining to Basilisp language modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant