Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_extension supported versions range #809

Closed
ikappaki opened this issue Jan 15, 2024 · 3 comments
Closed

typing_extension supported versions range #809

ikappaki opened this issue Jan 15, 2024 · 3 comments

Comments

@ikappaki
Copy link
Contributor

ikappaki commented Jan 15, 2024

Hi,

would it be possible to extend the typing_extensions version coverage to begin at 4.7 so as to support environments constrained on at least that version.

e.g.

typing_extensions = "^4.7.0"

It is currently set to ^4.9.0. I've tested this to work with 4.7.0 and pytests pass, though I'm not sure if this can have any diverse impact at runtime (I assume there is none).

Thanks

@chrisrink10
Copy link
Member

Can you give me more information as to why this is necessary or useful?

@ikappaki
Copy link
Contributor Author

ikappaki commented Jan 16, 2024

Can you give me more information as to why this is necessary or useful?

Because of python environments that have a typing_extensions constrain of 4.7.x version that is outside of the user control to modify. Basilisp can't be installed in such environments because of that version constraint.

This is an example of a request to permit earlier versions of a Basilisp dependency because Basilisp can't be installed in an environment that constrains the versions of some dependencies installed.

@chrisrink10
Copy link
Member

Fixed in #827

@chrisrink10 chrisrink10 added this to the Release v0.1.0b1 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants