Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basilisp.test/is expected value misreporting as falsy #965

Closed
ikappaki opened this issue Aug 16, 2024 · 0 comments · Fixed by #966
Closed

basilisp.test/is expected value misreporting as falsy #965

ikappaki opened this issue Aug 16, 2024 · 0 comments · Fixed by #966
Labels
issue-type:bug Something isn't working lang Issue pertaining to Basilisp language modules

Comments

@ikappaki
Copy link
Contributor

Hi,

basilisp.test/is is misreporting the expected value to be falsy when is asserting a function or falsy value:

FAIL in (issue) (issue_test.lpy:6)
    Test failure: false

    expected: false
      actual: false

To reproduce

  1. create a tests/basilisp/issue_test.lpy file with a falsy function call
(ns tests.basilisp.issue-test
  (:require
   [basilisp.test :refer [deftest is testing]]))

(deftest issue
  (is (some #{7} #{10 11})))

  1. run pytest, you should see the expected value reported as nil where in fact should be (not nil):
$ poetry run pytest -k issue
================================================= test session starts =================================================
configfile: pyproject.toml
plugins: anyio-4.4.0, basilisp-0.1.0, pycharm-0.7.0
collected 3334 items / 3333 deselected / 1 selected

tests\basilisp\issue_test.lpy F                                                                                  [100%]

====================================================== FAILURES =======================================================
________________________________________________________ issue ________________________________________________________
FAIL in (issue) (issue_test.lpy:6)
    Test failure: (some #{7} #{10 11})

    expected: nil
      actual: nil
=============================================== short test summary info ===============================================
FAILED tests/basilisp/issue_test.lpy::issue

PR to follow.

@chrisrink10 chrisrink10 added issue-type:bug Something isn't working lang Issue pertaining to Basilisp language modules labels Aug 24, 2024
@chrisrink10 chrisrink10 added this to the Release v0.2.0 milestone Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-type:bug Something isn't working lang Issue pertaining to Basilisp language modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants