Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 Fix + 1 Enhancement: Category Header not shown and remove active when !selectOnBlur #391

Open
leenooks opened this issue May 26, 2020 · 1 comment

Comments

@leenooks
Copy link

Hi,

I noticed that category headers were not being shown, because this is not available in .each(). that was defined, but should be used.

Also, I've added removing the active element when moving the mouse outside of the list, if selectOnBlur = false .

Hopefully you find it useful:

> $ diff bootstrap3-typeahead.js bootstrap3-typeahead.js.orig
345c345
<                 if (that.showCategoryHeader) {
---
>                 if (this.showCategoryHeader) {
658,660d657
<             if (! this.selectOnBlur) {
<                  this.$menu.find('.active').removeClass('active');
<             }
@MacJoom
Copy link

MacJoom commented Sep 5, 2020

I approve the fix (see #357)- could not test the enhancment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants