Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or fix Bootstrap import in scss file #12

Open
wimski opened this issue Jan 25, 2019 · 1 comment
Open

Remove or fix Bootstrap import in scss file #12

wimski opened this issue Jan 25, 2019 · 1 comment

Comments

@wimski
Copy link

wimski commented Jan 25, 2019

The Bootstrap import in typeaheadjs.scss does not work with the current release of Bootstrap 4. The import states...

@import '../bootstrap4/bootstrap-4-dev/scss/bootstrap.scss';

..., but the current path should be...

@import '../bootstrap/scss/bootstrap';

Please either fix the import statement or remove it all together so people are in control of the exact Bootstrap import.

[ EDIT ]
It seems the import statement is removed in the scss file, but when adding the package with yarn the import is still there. How come?

@tdeck
Copy link

tdeck commented Jan 6, 2020

I'm pretty sure this just needs a version bump and a new publish to npm. For now I'm pulling the code directly from this git repository rather than the NPM repo:

  // In package.json
  "dependencies": {
    "typeahead.js-bootstrap4-css": "git+ssh://git@github.com:bassjobsen/typeahead.js-bootstrap4-css.git#f589b59adc5cbe3aed11bbdae7906a56b432cf92"
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants