Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation of k-point meshes crashes for non-periodic systems #45

Open
bastonero opened this issue Aug 22, 2023 · 1 comment
Open

Generation of k-point meshes crashes for non-periodic systems #45

bastonero opened this issue Aug 22, 2023 · 1 comment

Comments

@bastonero
Copy link
Owner

The create_directional_kpoints method crashes when calling pymathen for molecules.
The relevant traceback:

    pymat = structure.get_pymatgen_structure()
  File "/home/bastonero/.conda/envs/aiida/lib/python3.8/site-packages/aiida/orm/nodes/data/structure.py", line 1292, in get_pymatgen_structure
    return self._get_object_pymatgen_structure(**kwargs)
  File "/home/bastonero/.conda/envs/aiida/lib/python3.8/site-packages/aiida/orm/nodes/data/structure.py", line 1838, in _get_object_pymatgen_structure
    raise ValueError('Periodic boundary conditions must apply in all three dimensions of real space')
ValueError: Periodic boundary conditions must apply in all three dimensions of real space

Per se this is not an issue as with molecules one is supposed to use only 1 kpoints. A possibility is to simply block the use of the kpoints_parallel_distance from the inputs for non periodic structures.

An other question is how to treat 1D and 2D materials. From the error, it seems pymatgen will complain. Since the projection onto crystal lattice is a very cheap operation, the call to pymatgen structure can be dropped and a custom solution implemented.

@bastonero bastonero changed the title Generation of k-point meshes crash for non-periodic systems Generation of k-point meshes crashes for non-periodic systems Aug 22, 2023
@bastonero
Copy link
Owner Author

This is actually a problem related to this PR aiidateam/aiida-core#6281 (comment)
The solution will then simply to update the dependencies of aiida-core to the future version where this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant