Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf from 3.16.0 to 3.18.3 in /python #150

Merged
merged 4 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/protobuf.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ message(STATUS "")
message(STATUS "Fetching protocolbuffers/protobuf")
FetchContent_Declare(protobuf
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
URL "https://github.com/protocolbuffers/protobuf/archive/refs/tags/v3.16.0.tar.gz"
URL "https://github.com/protocolbuffers/protobuf/archive/refs/tags/v3.19.0.tar.gz"
)
FetchContent_MakeAvailable(protobuf)

Expand Down
2 changes: 1 addition & 1 deletion python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
2to3
matplotlib>=2.0.1
numpy>=1.18.4
protobuf==3.16.0
protobuf==3.19.0
python-dotenv>=0.20.0
3 changes: 2 additions & 1 deletion python/tests/test_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ def test_run_mcmc():
eval_dens, nclus, clus, best_clus, chains = run_mcmc(
"NNIG", "DP", data, GO_PARAMS, DP_PARAMS,
ALGO_PARAMS, None, return_clusters=False,
return_num_clusters=False, return_best_clus=False)
return_num_clusters=False, return_best_clus=False,
return_chains=True)
assert eval_dens is None
assert nclus is None
assert clus is None
Expand Down