Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presence of DOCTYPE throws off map loader #32

Closed
bjorn opened this issue Nov 28, 2017 · 0 comments
Closed

Presence of DOCTYPE throws off map loader #32

bjorn opened this issue Nov 28, 2017 · 0 comments
Labels
bug

Comments

@bjorn
Copy link

bjorn commented Nov 28, 2017

The orthogonal-outside.tmx example shipping with Tiled has a DTD reference included as follows:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE map SYSTEM "http://mapeditor.org/dtd/1.0/map.dtd">
<map version="1.0" orientation="orthogonal" renderorder="right-down" width="45" height="31" tilewidth="16" tileheight="16" nextobjectid="37">
...

When trying to load that map with this library, it throws the following somewhat confusing error:

xml parser: missing 'orientation' attribute in the 'map' element
@bjorn bjorn changed the title Precense of DOCTYPE throws off map loader Presence of DOCTYPE throws off map loader Nov 28, 2017
@baylej baylej added the bug label Nov 28, 2017
@baylej baylej closed this as completed in 6903e8a Nov 28, 2017
baylej added a commit that referenced this issue Jun 16, 2020
@baylej
Release TMX for QtTiled 1.1
edc0274 
It includes the following new features:
+ Explicitely fail to load infinite maps
+ Support object templates
+ Add documentation in rst format, generate HTML doc using sphinx
+ Add emscripten compatibility (HTML5 support)
+ #39 Support alpha channel for colours
+ #41 Add functions to convert colours

It includes the following bug fixes:
+ #32 Ignore DOCTYPE element in XML document
+ Add missing freeing of object properties
+ Fix parsing of staggered map orientation
+ #33 Fix parsing of text wrap attribute
+ #34 Support uncompressed base64 encoded layers
+ #36 Cast to float the value returned by `atof`
+ Add missing `extern` qualifier to global variable
+ Use `uint32_t` for GIDs

It includes the following maintenance patches:
+ Mordernize CMake scripts
+ Add CI/CD pipelines using github actions
+ #47 CMake: Add src/ to the include directories
+ #48 Change file permissions from 755 to 644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjorn @baylej