Casted atof to float #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baylej
added a commit
that referenced
this pull request
Jun 16, 2020
It includes the following new features: + Explicitely fail to load infinite maps + Support object templates + Add documentation in rst format, generate HTML doc using sphinx + Add emscripten compatibility (HTML5 support) + #39 Support alpha channel for colours + #41 Add functions to convert colours It includes the following bug fixes: + #32 Ignore DOCTYPE element in XML document + Add missing freeing of object properties + Fix parsing of staggered map orientation + #33 Fix parsing of text wrap attribute + #34 Support uncompressed base64 encoded layers + #36 Cast to float the value returned by `atof` + Add missing `extern` qualifier to global variable + Use `uint32_t` for GIDs It includes the following maintenance patches: + Mordernize CMake scripts + Add CI/CD pipelines using github actions + #47 CMake: Add src/ to the include directories + #48 Change file permissions from 755 to 644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Visual C++ 15.8.9, atof produces a double variable, with this change, the variable is casted to float.