Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove non-bzlmod dep on @internal_platforms_do_not_use//host:constraints.bzl now that root workspace is bzlmod-only #916

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Aug 20, 2024

Now that #915 landed we can remove this sadness.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

…constraints.bzl now that root workspace is bzlmod-only
@gregmagolan gregmagolan requested review from jbedard and kormide August 20, 2024 18:32
Copy link

aspect-workflows bot commented Aug 20, 2024

Test

4 test targets passed

Targets
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild]    142ms
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild] 206ms
//lib/tests/jq:check_stamped [k8-fastbuild]                  219ms
//lib/tests/yq:check_stamped [k8-fastbuild]                  359ms

Total test execution time was 926ms. 217 tests (98.2%) were fully cached saving 58s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 750ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 742ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan requested a review from thesayyn August 20, 2024 18:41
@gregmagolan gregmagolan merged commit 0870fad into main Aug 20, 2024
34 checks passed
@gregmagolan gregmagolan deleted the cleanup_non_bzlmod_sadness branch August 20, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants