fix: xz decompression issues #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing e2e is unrelated. Fix for that is here: #179 |
jmillikin
approved these changes
Nov 25, 2024
alexeagle
approved these changes
Nov 25, 2024
kormide
force-pushed
the
close-writer
branch
from
d7616f1 to
b048646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the writable stream to end before reading the extracted module file. Also pause subsequent writes while the write buffer needs to be drained. It's not clear why the latter is necessary as the docs suggest you can continue to do writes while undrained content continues to be buffered in memory. However, this seems to fix an issue where the extracted content was incorrect.
Example of a working publish on the dev environment: publish-to-bcr-dev-registry/bazel-central-registry#82.
Closes #176.