From f731dcd3c5ce082fbc8478108529032b68da49ec Mon Sep 17 00:00:00 2001
From: Brian Barnes <brian@vicarious.com>
Date: Tue, 28 Aug 2018 19:02:46 -0700
Subject: [PATCH] implements pcl cmake_external build rule

---
 examples/cmake_pcl/BUILD | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/examples/cmake_pcl/BUILD b/examples/cmake_pcl/BUILD
index 52f193330..9a951b461 100644
--- a/examples/cmake_pcl/BUILD
+++ b/examples/cmake_pcl/BUILD
@@ -17,33 +17,43 @@ cmake_external(
         "BLAS_LIBRARIES": "$EXT_BUILD_DEPS/openblas/lib/libopenblas.a",
     },
     headers_only = True,
+    out_include_dir = "include/eigen3",
     lib_source = "@eigen//:all",
     deps = [":openblas"],
 )
 
+
 cmake_external(
     name = "flann",
-    cache_entries = {
-    },
     lib_source = "@flann//:all",
-    static_libraries = [
-        "libflann_s.a",
-        "libflann_cpp_s.a",
-    ],
+    static_libraries = ["libflann_s.a"],
 )
 
-# todo additional dependencies needed
 cmake_external(
     name = "pcl",
     cache_entries = {
         "WITH_LIBUSB": "no",
-        "EIGEN_INCLUDE_DIR": "$EXT_BUILD_DEPS/eigen/include",
+        "EIGEN_INCLUDE_DIRS": "$EXT_BUILD_DEPS/eigen/include",
         "FLANN_LIBRARY": "$EXT_BUILD_DEPS/flann/lib/libflann_s.a",
-        "FLANN_INCLUDE_DIR": "$EXT_BUILD_DEPS/flann/include",
+        "FLANN_INCLUDE_DIRS": "$EXT_BUILD_DEPS/flann/include",
+        "WITH_PNG": "no",
+        "WITH_QHULL": "no",
+        "WITH_CUDA": "no",
+        "WITH_QT": "no",
+        "WITH_VTK": "no",
+        "WITH_PCAP": "no",
+        "WITH_OPENGL": "no",
+        "WITH_OPENNI": "no",
+        "WITH_OPENNI2": "no",
+        "WITH_FZAPI": "no",
+        "WITH_ENSENSO": "no",
+        "WITH_DAVIDSDK": "no",
+        "WITH_DSSDK": "no",
+        "WITH_RSSDK": "no",
     },
-    cmake_options = ["-DBUILD_WITH_OPENMP=False"],
     headers_only = True,
     lib_source = "@pcl//:all",
+    out_include_dir = "include/pcl-1.8",
     deps = [
         ":eigen",
         ":flann",