Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
  • Loading branch information
ylecornec and fmeum authored May 31, 2023
1 parent 226cab6 commit 92ac50a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions go/private/extensions.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ load("//go/private:repositories.bzl", "go_rules_dependencies")
def host_compatible_toolchain_impl(ctx):
ctx.file("BUILD.bazel")
ctx.file("defs.bzl", content = """
host_compatible_sdk = Label("{}")
""".format(ctx.attr.toolchain))
host_compatible_sdk = Label({})
""".format(repr(ctx.attr.toolchain)))

host_compatible_toolchain = repository_rule(
implementation = host_compatible_toolchain_impl,
attrs = {
# We cannot use attr.label for the `toolchain` attribute since the module extension cannot
# refer to the repositories it creates by their apparent repository names.
"toolchain": attr.string(
doc = "The label of a `ROOT` file in the repository of a host compatible toolchain",
doc = "The apparent label of a `ROOT` file in the repository of a host compatible toolchain created by the `go_sdk` extension",
mandatory = True,
),
},
Expand Down

0 comments on commit 92ac50a

Please sign in to comment.