Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goleak broken by recent timeout changes #3938

Closed
DolceTriade opened this issue May 8, 2024 · 0 comments · Fixed by #3939
Closed

goleak broken by recent timeout changes #3938

DolceTriade opened this issue May 8, 2024 · 0 comments · Fixed by #3939

Comments

@DolceTriade
Copy link
Contributor

What version of rules_go are you using?

0.47.1

What version of gazelle are you using?

latest

What version of Bazel are you using?

bazel 6

Does this issue reproduce with the latest releases of all the above?

yes

What operating system and processor architecture are you using?

Linux amd64

Any other potentially useful information about your toolchain?

not relevant

What did you do?

Ran tests using goleak

What did you expect to see?

successful tests

What did you see instead?

tests failing with a lingering goroutine

This is because in the past we would register the go channel handler in a deterministic location (ie, bzltestutil), but now since its injected into main(), the name depends on the name of the target, which is not deterministic to ignore.

We should bring back the RegisterTimeoutHandler so we have a deterministic location to ignore again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant