Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3543
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds a new
custom
tag to thego_sdk
module extension.This tag is used to declare custom go toolchains to rules_go, to take them into consideration when creating the
go_host_compatible_sdk
repository introduced in #3543.Which issues(s) does this PR fix?
See bazel-contrib/bazel-gazelle#1469
Other notes for review
The attribute of the
custom
tag is not directly the label of a toolchain, but the label of a file containing atoolchain
variable. This way the file can be generated by the user in a repository rule (and thetoolchain
variable can be set toNone
to be deactivated if some conditions are not met).Custom toolchains have precedence over other ones (defined in the same module) because the user can deactivate them if needed.