Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest stamping prefixes all jars with "processed_" #786

Open
ghost opened this issue Nov 8, 2022 · 1 comment
Open

manifest stamping prefixes all jars with "processed_" #786

ghost opened this issue Nov 8, 2022 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 8, 2022

#771 enabled manifest stamping by default. This results in mutating third-party jars (which breaks SBOM verification) as well as inserting a "processed_" prefix in all file names. My deployments began failing because other non-Bazel projects cannot locate jars by name such as "commons-foo-1.2.3.jar" at runtime.

In the meantime, I can move forward by adding a --@rules_jvm_external//settings:stamp_manifest=false on the cmdline. However, as it involves mutating and renaming third-party artifacts, IMO manifest stamping should never be the default.

@JaredNeil
Copy link
Contributor

Similar to JetBrains/bazel-bsp#403, the Bloop compiler also expects to find a jar file that starts with scala-compiler. Could the stamping be changed to create the unstamped files as unprocessed_*.jar and then the final files could have the canonical file name without a prefix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant